Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The syntax in website is missing JSXFragment as JSXChild #128

Closed
koba04 opened this issue Feb 20, 2021 · 0 comments · Fixed by #135
Closed

The syntax in website is missing JSXFragment as JSXChild #128

koba04 opened this issue Feb 20, 2021 · 0 comments · Fixed by #135

Comments

@koba04
Copy link

koba04 commented Feb 20, 2021

The syntax in the official website doesn't allow JSXFragment as JSXChild.
It has been added in the master branch by #97, but it hasn't been synced to the website.

https://facebook.github.io/jsx/

Could you update the website to apply the change?
Currently, most of the compilers allow the syntax, so it should be allowed.
@koba04 koba04 mentioned this issue Feb 20, 2021
Closed
@Huxpro Huxpro mentioned this issue Feb 24, 2022
Merged
Huxpro added a commit that referenced this issue Feb 24, 2022
@Huxpro
Migrate to ecmarkup (#135)
148bf2a 
* Migrate to ecmarkup

This is the first step to revamp this repo: [ecmarkup](https://github.com/tc39/ecmarkup)
is TC39's official tool for specifying syntax and semantics for ECMAScript.
I proposed that we should adopt it because it has several favorabilities
than the current approach (`README.md` + a `gh-pages` website living in
the `websitescript` branch):
1. The resultant `index.html` has a similar looks and feels with the
   official ECMA-262 spec.
2. It uses [Grammarkdown](https://github.com/rbuckton/grammarkdown)
   which is not only convenient to write but more importantly, can
   enforce the grammar to be more formal.
3. It provides links to ECMA-262 out of the box (closed #112).
   Furthurmore, I can use `<ins>` to make "extension" points explicit.
4. It has single source of truth and prevent from syncing issue between the README and website (close The syntax in 
   website is missing JSXFragment as JSXChild #128)

One possible concern it that it'll make this too like a ECMAScript proposal,
but I think we mediated by opting-out from the "stage-N proposal"
heading, and by explicitly calling out our intention in the
"Introduction" section.

In addition,
- Link to JXON is updated since the original link no more existed.
- Parser and Transpiler section is dropped from the "spec" website.
- Facebook, Inc. is updated to Meta Platform, Inc everywhere.

Once this is merged, we can switch to `main` to host Github Pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to ecmarkup Huxpro/jsx
1 participant
@koba04