Add Contributing Guideline #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow-up of <#132 (comment)>, we should clarify the requirements and expectations on different kinds of contributions.
|
Feel free to comment or open an issue if you have any feedback |
Josh-Cena
reviewed
Mar 8, 2022
| @@ -104,6 +104,28 @@ Prior Art | |||
|
|
|||
| The JSX syntax is similar to the [E4X Specification (ECMA-357)](http://www.ecma-international.org/publications/files/ECMA-ST-WITHDRAWN/Ecma-357.pdf). E4X is a deprecated specification with deep reaching semantic meaning. JSX partially overlaps with a tiny subset of the E4X syntax. However, JSX has no relation to the E4X specification. | |||
|
|
|||
|
|
|||
| Contributing | |||
There was a problem hiding this comment.
Move to a separate file CONTRIBUTING.md so we can take advantage of GitHub's UI? https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors
There was a problem hiding this comment.
Make sense. Thanks for the feedback. Will do!
There was a problem hiding this comment.
Just realized there's already a pending #114 😄
There was a problem hiding this comment.
Hah yea I've been thinking of merge them into one ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up of #132 (comment), we should clarify the requirements and expectations on different kinds of contributions.