Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with Java 11 JDK #11

Closed
sgrimm opened this issue Dec 30, 2019 · 1 comment
Closed

Build fails with Java 11 JDK #11

sgrimm opened this issue Dec 30, 2019 · 1 comment

Comments

@sgrimm
Copy link
Contributor

sgrimm commented Dec 30, 2019

This seems to be a problem in google-java-format rather than in ktfmt, so the actual issue here is just that it should be documented in the README. Running mvn install with a Java 11 JDK (AdoptOpenJDK 11.0.5+10) fails:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on project google-java-format: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar failed.: NullPointerException -> [Help 1]

With a Java 8 JDK, it builds successfully.
@cgrushko
Copy link
Contributor

Let's see if google/google-java-format#429 helps.

@cgrushko cgrushko mentioned this issue Dec 30, 2019
Closed
facebook-github-bot pushed a commit that referenced this issue Jan 2, 2020
@cgrushko @facebook-github-bot
Run CI on JDK 11 and 13
45187ed 
Summary: This is in addition to JDK 1.8. Motivation: avoid #11 and #12 in the future.

Reviewed By: strulovich

Differential Revision: D19253564

fbshipit-source-id: 779244f4ba16f16c56e7c90793e4e531e6791ccd
@cgrushko cgrushko mentioned this issue Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update google-java-version to 05f57ec9610a6371c38106b5e356476f2223504f cgrushko/ktfmt
2 participants
@sgrimm @cgrushko