-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin doesn't work with if "Only VCS changed text" is selected from code-reformat settings #228
Comments
@cushon, is this somehow related to google/google-java-format@69ba30f#diff-58c63abbc548a9eecf5ec08ea5e513d00cbc788ad90b7704ae8fe27ef3111fa0 ? |
@cgrushko I think so, |
copybara-service bot
pushed a commit
to google/google-java-format
that referenced
this issue
May 12, 2021
Related: facebook/ktfmt#228 Follow-up to 69ba30f PiperOrigin-RevId: 372590998
copybara-service bot
pushed a commit
to google/google-java-format
that referenced
this issue
May 12, 2021
Related: facebook/ktfmt#228 Follow-up to 69ba30f PiperOrigin-RevId: 372590998
copybara-service bot
pushed a commit
to google/google-java-format
that referenced
this issue
May 12, 2021
Related: facebook/ktfmt#228 Follow-up to 69ba30f PiperOrigin-RevId: 372590998
copybara-service bot
pushed a commit
to google/google-java-format
that referenced
this issue
May 12, 2021
Related: facebook/ktfmt#228 Follow-up to 69ba30f PiperOrigin-RevId: 372590998
copybara-service bot
pushed a commit
to google/google-java-format
that referenced
this issue
May 12, 2021
Related: facebook/ktfmt#228 Follow-up to 69ba30f PiperOrigin-RevId: 373443663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is a snippet of code I had that was all formated by ktfmt
I added a line to the middle of it to make it this
and now when I reformat with the plugin. It doesn't fix the added line. In other files, it will actually reformat other parts of the file instead of the lines I added (really weird) even though the other parts of the file already had ktfmt ran on it.
I stumbled upon the issue as being related to cmd opt shit L dialog being set to "Only VCS changed text"
If I remove that and instead do "Whole file" then everything works as expected. Here is a video of the plugin not reformatting anything (which initially caused me to think the plugin wasn't triggered at all which made me open #223 )
Closing #223 in favor of this ticket
figureditout.mp4
The text was updated successfully, but these errors were encountered: