Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin version to 1.6.10 #266

Closed
wants to merge 2 commits into from

Conversation

mpetrov
Copy link
Contributor

@mpetrov mpetrov commented Dec 28, 2021

Running mvn install on macOS with JDK15 results in illegal access
exceptions. This appears to be a known issue that was fixed in 1.5.30:
https://youtrack.jetbrains.com/issue/KT-45689

It would be a nice quality of life improvement to bump the kotlin
version if this doesn't conflict with any internal flows.

Running `mvn install` on a macOS with JDK15 results in illegal access
exceptions. This appears to be a known issue that was fixed in 1.5.30:
https://youtrack.jetbrains.com/issue/KT-45689

It would be a nice quality of life improvement to bump the kotlin
version if this doesn't conflict with any internal flows.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 28, 2021
@facebook-github-bot
Copy link
Contributor

@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cgrushko
Copy link
Contributor

@mpetrov thanks! Maybe it's worth upgrading to 1.6?

@mpetrov mpetrov changed the title Update kotlin version to 1.5.32 Update kotlin version to 1.6.10 Dec 28, 2021
@mpetrov
Copy link
Contributor Author

mpetrov commented Dec 28, 2021

Sure, no issues bumping to 1.6.10 that I'm aware of.

@cgrushko PTAL

@cgrushko
Copy link
Contributor

Thanks! Waiting for the importer to pick this up. We don't have good coverage for the binary itself, any chance I can ask you to build and run the binary for sanity check?

@facebook-github-bot
Copy link
Contributor

@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mpetrov
Copy link
Contributor Author

mpetrov commented Dec 28, 2021

Yup, got No changes on all files after running:

mvn clean
mvn install
find core/src/ | egrep ".kt$" | xargs java -jar core/target/ktfmt-0.31-SNAPSHOT-jar-with-dependencies.jar

This is on macOS with java 15.0.2 2021-01-19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants