fix: comment max width #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
hick209
approved these changes
Aug 23, 2024
|
Wow, great catch! Thanks for the fix 😃 |
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormattingOptions#maxWidthis not respected for double slash comments. This is because it wasn't using the supplied value, and instead checked against the static propertycom.google.googlejavaformat.java.Formatter.MAX_LINE_LENGTH. I was unable to find any documentation / discussion that would indicate this as being intentional.Test cases that deduced
maxWidthactually relied on this behavior in some cases. Some of the fixes in 84dbfae simply adjusted the number of/, while others relied on a specificmaxWidthand so I manually line-broke the comments to preserve the behavior under test.