-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting Grammarly and Google Translate #53
Comments
Grammarly support added in #54. |
How about google translate? Is there any idea to get google translate available in readOnly mode? |
@li-yechao Does Google Translate not work at all with your Lexical content? Last time I checked, it worked fine for me. |
It not worked for me, example page: https://www.robertmao.com/blog/post/yvstwPLWHCsNz-XN What am I doing wrong here? |
Ah, it's because of Lexical's DOM mutation observers reverting the content back. I wonder if we should relax the DOM mutation listeners in non-editable mode. |
@li-yechao Can you open a separate issue for this please? We can track it and maybe come up with a solution. |
|
DraftJS doesn't work with either because of many reasons that either: conflict with React's rendering, or just don't support Draft's internal model. I feel that we should do better here.
These browser plugins are not only heavily used by a large majority of the Internet, they also provide a much better experience for users that depend on these for accessibility reasons (which includes plugins other than these two).
I feel like we should spent some effort on investigating and possibly implementing support for these browser plugins. We can obviously disable them (you can use DOM attributes and classes to do so) but I feel like we should at least explore this space.
The text was updated successfully, but these errors were encountered: