-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve & document NPM package addition process #5869
Comments
I think if we pull out the code I have in those two PRs into shared modules we can use that across the board to handle basically all of the hard-coded mess across the build scripts
|
@etrepum feel free to jump on it! I can later add Meta specific WWW build steps |
@StyleT will do, if you can get those PRs approved/merged (or at least one of them?) it would make it a little easier for me since AFAIK you can only stack on top of at most one of them as a base branch with the github workflow |
…s and build integration tests Extracted from facebook#5876 to hopefully land it in smaller chunks. Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
…s and build integration tests Extracted from facebook#5876 to hopefully land it in smaller chunks. Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
…s and build integration tests Extracted from facebook#5876 to hopefully land it in smaller chunks. Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
…s and build integration tests Extracted from facebook#5876 to hopefully land it in smaller chunks. Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
…s and build integration tests Extracted from facebook#5876 to hopefully land it in smaller chunks. Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
…s and build integration tests Extracted from facebook#5876 to hopefully land it in smaller chunks. Addresses the infrastructure needed for facebook#5869 (without the associated changes to scripts)
At this moment addition of the new NPM package to Lexical monorepo requires repetitive updates to ~10 different files. On top of that Meta specific WWW build requires separate changes done to internal codebase in order to keep it running.
Example:
In #5861 we reverted #5830 that added
@lexical/devtools-core
package. Later it was re-added in #5864 with fixes done to the build system.Scope:
The text was updated successfully, but these errors were encountered: