Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: simplified insertText rewrite (part 2) #6553

Open
GermanJablo opened this issue Aug 25, 2024 · 0 comments
Open

Refactor: simplified insertText rewrite (part 2) #6553

GermanJablo opened this issue Aug 25, 2024 · 0 comments

Comments

@GermanJablo
Copy link
Contributor

I'm opening this issue to follow up on part 2 of PR #6456.

In the first part I rewrote removeText so that it is not dependent on insertText.

The second part that is missing is to rewrite insertText with the new removeText.

My first draft version is in the codebase commented and is much shorter. But some tests are failing.

I don't think I'll be able to finish it anytime soon, so it's an open task for volunteers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant