[PR 3] Removed edge-cases of GridSelection #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 23, 2023 17:25
…-baseselection' into 5276-feature-gridselection-separation-from-lexical-core-gridselection-vs-nodeselection
…exical-core-baseselection
…-baseselection' into 5276-feature-gridselection-separation-from-lexical-core-gridselection-vs-nodeselection
…-baseselection' into 5276-feature-gridselection-separation-from-lexical-core-gridselection-vs-nodeselection
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
icrosil
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
added 2 commits
December 1, 2023 16:35
…-baseselection' into 5276-feature-gridselection-separation-from-lexical-core-gridselection-vs-nodeselection
added 6 commits
December 1, 2023 17:01
…-gridselection-vs-nodeselection' into 5276-feature-gridselection-separation-from-lexical-core-remove-grid-seleciton
…-baseselection' into 5276-feature-gridselection-separation-from-lexical-core-gridselection-vs-nodeselection
…-gridselection-vs-nodeselection' into 5276-feature-gridselection-separation-from-lexical-core-remove-grid-seleciton
Base automatically changed from
5276-feature-gridselection-separation-from-lexical-core-gridselection-vs-nodeselection
to
main
December 5, 2023 10:24
…exical-core-remove-grid-seleciton
size-limit report 📦
|
|
Hey @zurfyx , @fantactuka could you please help me review this PR? |
zurfyx
approved these changes
Dec 8, 2023
Comment on lines
342
to
345
| const rangeSelection = $createRangeSelection(); | ||
| rangeSelection.anchor.set(newAnchorCellKey, 0, 'element'); | ||
| rangeSelection.focus.set(newFocusCellKey, 0, 'element'); | ||
| $setSelection(rangeSelection); |
There was a problem hiding this comment.
This is a tricky one, I remember that a selection like this can break the table because you're essentially selecting the cells so operations like delete can make it inconsistent. I think that this entire function should be moved to the tables plugin and we can have a command to delegate handling this logic there.
We don't necessarily have to do it in this PR so you can leave GridSelection for now.
icrosil
deleted the
5276-feature-gridselection-separation-from-lexical-core-remove-grid-seleciton
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In #5276 we proposed a solution on how to migrate GridSelection out of the core of the bundle, here is the third step by removing edge-case usage of GridSelection to decrease dependencies.
What