Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to state update blog #5423

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Add link to state update blog #5423

merged 2 commits into from
Dec 27, 2023

Conversation

acywatson
Copy link
Contributor

Screenshot 2023-12-26 at 8 05 05 AM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 26, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 7:10pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 7:10pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.62 KB (0%) 533 ms (0%) 202 ms (+82.21% 🔺) 735 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.33 KB (0%) 787 ms (0%) 276 ms (+46.59% 🔺) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.3 KB (0%) 787 ms (0%) 225 ms (-1.79% 🔽) 1.1 s

DaniGuardiola
DaniGuardiola reviewed Dec 26, 2023
View reviewed changes
Copy link

@DaniGuardiola DaniGuardiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo :P

packages/lexical-website/docs/concepts/editor-state.md Outdated
@@ -70,6 +70,12 @@ won't be reflected in editor. See "Update state" below for proper ways of updati

## Updating state

:::tip

For a deep dive into how state updates works, check out [this blog post](https://dio.la/article/lexical-state-updates) by Lexical contributor [@DaniGuardiola](https://twitter.com/daniguardio_la).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For a deep dive into how state updates works, check out [this blog post](https://dio.la/article/lexical-state-updates) by Lexical contributor [@DaniGuardiola](https://twitter.com/daniguardio_la).
For a deep dive into how state updates work, check out [this blog post](https://dio.la/article/lexical-state-updates) by Lexical contributor [@DaniGuardiola](https://twitter.com/daniguardio_la).

@acywatson acywatson merged commit 58b84da into main Dec 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniGuardiola DaniGuardiola DaniGuardiola left review comments

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acywatson @ivailop7 @DaniGuardiola @facebook-github-bot