feat(@lexical/devtools): Publish pipeline added #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StyleT
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
StyleT
force-pushed
the
feature/devtools_publising
branch
from
c38bb93
to
0065b34
Compare
size-limit report 📦
|
acywatson
reviewed
Apr 19, 2024
|
|
||
| jobs: | ||
| release: | ||
| if: github.repository_owner == 'facebook' |
There was a problem hiding this comment.
what's the purpose of this condition?
acywatson
approved these changes
Apr 19, 2024
So signing happens at the store side after version review. We simply upload zip there and they do review + signing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds publish pipeline draft (as I'm still waiting for stores approval for FF/Edge + license update for Apple/Chrome).
All secrets were added to repo and I'll publish access request procedure in the follow up diff that adds Chrome/Safari