Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-devtools] The new collapsible node tree #6464

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaxPlav
Copy link
Contributor

@MaxPlav MaxPlav commented Jul 26, 2024

This diff is inspired by the react dev tools extension and suggests a lexical node tree for the dev tools extension mentioned in
#5675. The nodes tree is built on top of https://github.com/dgreene1/react-accessible-treeview. Currently, the tree can expand and collapse on a user click and hightlight the appropriate node in the lexical editor. The selected lexical node details and lexical selection details are displayed on the right panel.
The availability of the new tree is controlled by the env variable VITE_COLLAPSIBLE_TREE=1 in lexical-devtools package.

Testing on the dev environment:

  1. Go to lexical-devtools package.
  2. Set VITE_COLLAPSIBLE_TREE=1 in .env.development or .env.development.local.
  3. Run npm run dev.
Screenshot 2024-07-26 at 15 14 50
Screen.Recording.2024-07-26.at.15.11.27.mov

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 9:24pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 9:24pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

size-limit report 📦

Path Size
lexical - cjs 29.05 KB (0%)
lexical - esm 28.86 KB (0%)
@lexical/rich-text - cjs 37.39 KB (0%)
@lexical/rich-text - esm 28.33 KB (0%)
@lexical/plain-text - cjs 36.02 KB (0%)
@lexical/plain-text - esm 25.6 KB (0%)
@lexical/react - cjs 39.29 KB (0%)
@lexical/react - esm 29.77 KB (0%)

@StyleT StyleT added the extended-tests Run extended e2e tests on a PR label Jul 26, 2024
@etrepum
Copy link
Collaborator

etrepum commented Nov 13, 2024

@MaxPlav Is there a reason this is still in draft? What's left to do? It seems a bit odd to make it an environment toggle instead of either using it by default or having a setting in the UI somewhere to turn it on or off, but otherwise at a glance it looks like this might be usable in its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants