-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-playground] Fix: tabs do not show strikethrough/underline #6811
Open
vantage-ola
wants to merge
19
commits into
facebook:main
Choose a base branch
from
vantage-ola:fix-strikethrough-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1fa2f41
fix: tabs do not show strikethrough
vantage-ola 2e191b4
Merge branch 'main' into fix-strikethrough-issue
vantage-ola 9e3b6ed
Merge branch 'main' into fix-strikethrough-issue
vantage-ola e34cb0a
fix: strikethrough-underline space/tabs issue
vantage-ola be6f2d8
remove: white-space:pre
vantage-ola 7108224
Merge branch 'main' into fix-strikethrough-issue
vantage-ola d7cce91
Merge branch 'main' into fix-strikethrough-issue
vantage-ola 4e8b547
Merge branch 'main' into fix-strikethrough-issue
vantage-ola 2abd826
Merge branch 'main' into fix-strikethrough-issue
vantage-ola 6bd1a8b
Merge branch 'main' into fix-strikethrough-issue
vantage-ola a0a7b23
Merge branch 'main' into fix-strikethrough-issue
vantage-ola 0f3aa75
return to original styling
vantage-ola 4b2861c
rough fix - special class for concerned tabNodes
vantage-ola 6ee08c7
Merge branch 'main' into fix-strikethrough-issue
vantage-ola dd6ad32
Merge branch 'main' into fix-strikethrough-issue
vantage-ola b02311a
tabnode class fix: remove unnessary methods
vantage-ola 18adaa3
remove css
vantage-ola 76d6ece
Merge branch 'main' into fix-strikethrough-issue
vantage-ola e2fd5ef
Merge branch 'main' into fix-strikethrough-issue
vantage-ola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not a playground-only node, this class needs to come from the theme and not be hardcoded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, what do you mean by 'come from the theme and not be hardcoded?'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition you would need to modify the
EditorThemeClasses
type and add the propertytab: 'PlaygroundEditorTheme__tabNode'
to PlaygroundEditorTheme.ts