fix: bug-6851 #6854
fix: bug-6851 #6854
Conversation
emsurezhang
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
| @@ -1778,7 +1778,7 @@ export class RangeSelection implements BaseSelection { | |||
| possibleNode.selectStart(); | |||
| return; | |||
| } | |||
| this.modify('extend', isBackward, 'character'); | |||
| this.modify('move', isBackward, 'character'); | |||
There was a problem hiding this comment.
I don't think this change is correct but we can run the tests and see how many will fail. I haven't looked at this code closely recently but I believe the extend is intentional, to grow a collapsed selection by one character and then delete the contents of that selection.
There was a problem hiding this comment.
Here's a link to the unit test failure report: https://github.com/facebook/lexical/actions/runs/11956172962/job/33332485265?pr=6854
etrepum
added
the
stale-pr
|
I'm going to close this as stale, since this change does not include tests and causes regressions elsewhere. Please feel free to re-open or create a new PR when you have something that works without regressions. |
#6851
update:
in LexicalSelection.ts file, change the native selection move mode from "extend" to "move", cause isCollapsed is true.
at line 1781:
this.modify('extend', isBackward, 'character'); => this.modify('move', isBackward, 'character');