Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-table] Bug Fix: Fix table tab navigation #6880

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[lexical-table] Bug Fix: Fix table tab navigation #6880

merged 2 commits into from
Nov 28, 2024
+375 −34

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Nov 28, 2024 •
edited
Loading

Description

Fixes tab navigation in tables when merged cells are present

Closes #6878
Closes #6729

Test plan

Before

table-tab-before.mov

After

table-tab-after.mov

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 6:36pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 6:36pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2024
@etrepum etrepum marked this pull request as ready for review November 28, 2024 16:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 30.92 KB (0%)
lexical - esm 30.83 KB (0%)
@lexical/rich-text - cjs 39.73 KB (0%)
@lexical/rich-text - esm 32.65 KB (0%)
@lexical/plain-text - cjs 38.32 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.46 KB (0%)
@lexical/react - esm 34 KB (0%)

@etrepum etrepum changed the title Fix table tab navigation [lexical-table] Bug Fix: Fix table tab navigation Nov 28, 2024
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Nov 28, 2024
@etrepum etrepum added this pull request to the merge queue Nov 28, 2024
Merged via the queue into facebook:main with commit 16e4987 Nov 28, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: tab through table cells containing merged cells Bug: Nested tables - tab key handling
3 participants
@etrepum @ivailop7 @facebook-github-bot