Fix lint warnings and code duplication

Reviewed By: muraziz Differential Revision: D16709380 fbshipit-source-id: 554e006f4da879391d77b47bd9567d3247201b4a
facebook · Aug 9, 2019 · fa3466b · fa3466b
1 parent ac513f3
commit fa3466b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/litho-core/src/main/java/com/facebook/litho/DefaultInternalNode.java b/litho-core/src/main/java/com/facebook/litho/DefaultInternalNode.java
@@ -82,7 +82,7 @@ public class DefaultInternalNode implements InternalNode, Cloneable {
   private static final boolean SUPPORTS_RTL = (SDK_INT >= JELLY_BEAN_MR1);
 
   // Flags used to indicate that a certain attribute was explicitly set on the node.
-  private static final long PFLAG_LAYOUT_DIRECTION_IS_SET = 1L << 0;
+  private static final long PFLAG_LAYOUT_DIRECTION_IS_SET = 1L;
   private static final long PFLAG_ALIGN_SELF_IS_SET = 1L << 1;
   private static final long PFLAG_POSITION_TYPE_IS_SET = 1L << 2;
   private static final long PFLAG_FLEX_IS_SET = 1L << 3;
@@ -1760,7 +1760,6 @@ private void setIsPaddingPercent(YogaEdge edge, boolean isPaddingPercent) {
   }
 
   private void setPaddingFromBackground(Drawable drawable) {
-
     if (drawable != null) {
       final Rect backgroundPadding = new Rect();
       if (getDrawablePadding(drawable, backgroundPadding)) {
@@ -1802,10 +1801,7 @@ private void updateWith(ComponentContext c, YogaNode node, List<Component> compo
     mComponentsNeedingPreviousRenderData = null;
     for (Component component : components) {
       if (component.needsPreviousRenderData()) {
-        if (mComponentsNeedingPreviousRenderData == null) {
-          mComponentsNeedingPreviousRenderData = new ArrayList<>(1);
-        }
-        mComponentsNeedingPreviousRenderData.add(component);
+        addComponentNeedingPreviousRenderData(component);
       }
     }
 

diff --git a/litho-core/src/main/java/com/facebook/litho/NodeInfo.java b/litho-core/src/main/java/com/facebook/litho/NodeInfo.java
@@ -64,9 +64,9 @@ public interface NodeInfo {
   @Retention(RetentionPolicy.SOURCE)
   @interface SelectedState {}
 
-  static final int ACCESSIBILITY_HEADING_UNSET = 0;
-  static final int ACCESSIBILITY_HEADING_SET_TRUE = 1;
-  static final int ACCESSIBILITY_HEADING_SET_FALSE = 2;
+  int ACCESSIBILITY_HEADING_UNSET = 0;
+  int ACCESSIBILITY_HEADING_SET_TRUE = 1;
+  int ACCESSIBILITY_HEADING_SET_FALSE = 2;
 
   @IntDef({
     ACCESSIBILITY_HEADING_UNSET,