Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out "Remove Flipper integration temporarily (#985)" #1006

Closed
wants to merge 1 commit into from
Closed

Conversation

passy
Copy link
Member

@passy passy commented Jul 17, 2024

Original commit changeset: 90df873

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Jul 17, 2024
Summary:
Preparing to backout the Flipper removal. Finally got the new Flipper release out. This will require a new JDK version though to compile.

Separate commit so that the next one cleanly backs out without additional changes.

Pull Request resolved: #1005

Test Plan:
./gradlew :sample:installDebug

Next diff in stack:

<img width="1448" alt="Screenshot 2024-07-17 at 15 26 43" src="https://github.com/user-attachments/assets/dfd8a700-8477-4e47-96e0-db271ed7de54">
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/litho/pull/1005).
* #1006
* __->__ #1005

Reviewed By: zielinskimz

Differential Revision: D59860785

Pulled By: passy

fbshipit-source-id: c9f5aa51bec0d0bc06ab23fec883ff150639bdb2
@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 145d942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants