Eliminate Gradle deprecated methods #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There were some warnings for deprecated stuff that will be removed in Gradle 6.0. This commit eliminates them and replaces the previous usages with the equivalent providers. e.g.: `getArchiveClassifier()`, `javaCompileProvider`
There was a problem hiding this comment.
@muraziz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Great stuff, as always. Thanks, @pavlospt! |
passy
approved these changes
Apr 3, 2019
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 9, 2019
Summary: Cleanup deprecations left after facebook#526 fbshipit-source-id: 00d8cf860ae35a25eea773d1f65700a0072f2c54
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 9, 2019
Summary: Cleanup deprecations left after facebook#526 Differential Revision: D14853880 fbshipit-source-id: 65569f751a151ca3a686c3d71699fef32cd6a6f7
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some warnings for deprecated stuff that will be removed in Gradle 6.0. This PR eliminates them and replaces the previous usages with the equivalent providers.
e.g.:
getArchiveClassifier(),javaCompileProvider