Added gap support to rows and columns #959
Conversation
| protected @Nullable YogaGutter mGap; | ||
| protected @Nullable Integer mGapLength; |
There was a problem hiding this comment.
We are in the process of generalising the implementation of LithoNode (i.e. decouple Litho and Yoga) so we don't recommend adding new Yoga props to LithoNode. Instead they should be implemented using the LayoutProps APIs.
New gap, and gapLength APIs can be added to the LayoutProps interface. Then implement the new APIs in CommonProps for the component to write to, and YogaPropsWriter for the YogaNode to be written to.
The API can then be exposed to Row and Column component builders by adding new setters in (ContainerBuilder)[https://github.com/facebook/litho/blob/master/litho-core/src/main/java/com/facebook/litho/Component.java#L2161]. In the implementation it would call the new API on the common props.
There was a problem hiding this comment.
Thanks so much for the feedback, I will give this a go and reach out if I need any support
|
@adityasharat I pushed the changes but I'm having issues building the project on master and on the branch to run the unit tests. is there some documentation around this? |
…onProps and YogaLayoutProps * updated LayoutProp, CommonProps, DefaultProps and test with gap logic * updated YogaLayoutProps with yoga node call * removed setGap logic in LithoNode
|
That is odd. It fails to compile with the changes in this PR or it fails to compile even on master? In this context there are only a couple of places where mutable list of components are used:
|
* updated the api for Column and Row to support pixels and dips
stevenkang90
force-pushed
the
gap_support
branch
from
8a71095 to
7c54467
Compare
Hi @adityasharat I've had a few issues building the project to be honest.
I've managed to deploy and test the changes by integrating them into some feature work so I'm confident it works. |
|
I think the fastest way to unblock you would be to import the PR into our source! I'm on it. |
|
@adityasharat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@adityasharat merged this pull request in 7644be3. |
|
Hi @adityasharat were these changes ever released, We deployed an internal artifact to get gap support, recently we updated to 0.49.0 and can't see any gap support in that release still. |
Summary
YogaLayout 2.0.0 added support for gaps, this PR plugs that into Litho to allow usage in clients
Changelog
Test Plan