Skip to content

Commit

Permalink
Use HandlerCallbackPtr<T> instead of std::unique_ptr<HandlerCallback<…
Browse files Browse the repository at this point in the history
…T>> (part 2)

Summary:
This is a follow-up of {D55937714} with some cases missed from the original codemod because of whitespaces not being accounted for in the regex. Like the parent diff, this is a no-op.

```
$ codemod -m '(std::)?unique_ptr\s*<\s*(apache::thrift::)?HandlerCallback\s*<(.*?)>\s*' '\2HandlerCallbackPtr<\3'
```

Reviewed By: thedavekwon

Differential Revision: D55983582

fbshipit-source-id: 3181ad2a96a4ed24355a6148cd18d37dbdb0e3e6
  • Loading branch information
praihan authored and facebook-github-bot committed Apr 11, 2024
1 parent 8b8aeca commit ed89259
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions mcrouter/lib/carbon/example/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ class ThriftHandler : virtual public hellogoodbye::thrift::HelloGoodbyeSvIf {
}

void async_eb_goodbye(
std::unique_ptr<
apache::thrift::HandlerCallback<hellogoodbye::GoodbyeReply>> callback,
apache::thrift::HandlerCallbackPtr<hellogoodbye::GoodbyeReply> callback,
const hellogoodbye::GoodbyeRequest& request) override {
LOG(INFO) << "Good bye! Thrift server " << reinterpret_cast<uintptr_t>(this)
<< " got key " << request.key_ref()->fullKey().str();
Expand Down

0 comments on commit ed89259

Please sign in to comment.