Fix OSS build #445
Closed
Fix OSS build #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszabo-wikia
force-pushed
the
fix-oss-build
branch
from
59cfd85 to
7004dae
Compare
mszabo-wikia
force-pushed
the
fix-oss-build
branch
3 times, most recently
from
8ece572 to
47987db
Compare
mcrouter currently does not compile, since the build system is out of sync with recent changes. Due to the use of `std::span` introduced in 9a24a4e, the project now requires C++20 to build. Update the `-std` flag accordingly, since the existing C++17 requirement was also introduced without much fanfare in 3181213 following a similar change. Also update Automake files to reflect some newly added project files, and link against `serverdbginfo` and `runtime` from fbthrift, since they are now required.
mszabo-wikia
force-pushed
the
fix-oss-build
branch
from
47987db to
367ee71
Compare
|
@stuclar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcrouter currently does not compile, since the build system is out of sync with recent changes.
Due to the use of
std::spanintroduced in9a24a4e, the project now requires C++20 to build. Update the
-stdflag accordingly, since the existing C++17 requirement was also introduced without much fanfare in 3181213 following a similar change.Also update Automake files to reflect some newly added project files, and link against
serverdbginfoandruntimefrom fbthrift, since they are now required.