-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metro won't work on Windows for react native #181
Comments
@rafeca Can you help on this issue ? |
Hey @gengjiawen , from the logs I understand that you're trying to build an android app from Windows right? Can you paste all the logs since you start Metro? It looks like the project roots may not be configured properly |
The app is react-native RNTester. It's in this branch https://github.com/gengjiawen/react-native/tree/feature/RNTester_start. The full log is
|
@rafeca I created an related pr in react-native facebook/react-native#19974. Hope with that pr you can reproduce this issue easily. |
@rafeca Can you take some time to take a look on this. I really want to debug react native source code on windows. |
+1 @rafeca Just updated to 0.56 and borked. Edit: Rolled back to 0.55.4 and app is working again. Will take a read through this. |
@mjesun Can you help on the issue ? |
same issue. any solution? |
any solution? |
I think @pvdz was looking at a fix; it seems to be related to Babel changing their normalization path. |
Reviewed By: davidaurelio Differential Revision: D8735223 fbshipit-source-id: 646f03a6192699a8f890e19cdcafee1631332251
Looks like the problem still exists. |
A new version of Metro bundler 0.38.2 (and Metro 0.42.1) has been released with a fix for the path normalisation. Please provide a repro if the issue still persist with the new version. |
I am not with my pc for now. But if you have a pc, you can try the repro repo. I will give a test when I get home. |
@kelset @gengjiawen Tried 0.42.1 and 0.38.2 on my win 10 pc, no success. I am getting Unable to resolve module |
I know, many devs prefer macOS or linux. But windows has lots of user too. The repro steps is simple and clear. Please spare some time for this issue. |
Same problem. Version facebook/react-native: 0.56 Rolled back to 0.55.4 and app is working again. |
because of this issue? |
A month old blocking issue? Tried a few things but cannot get it to work on Windows. |
Very frustrating, a stable version with a bug and no attention and explanation for a fix 👎 |
First of all apologies for the delay answering. It was hard to debug Windows issues since I didn't have any Windows machine to be able to reproduce it. Now I got one and I'm working on a fix, which should come very soon |
@rafeca No, still has issue, please reopen.
|
This is still an issue for some developers is my team, please reopen. |
Folks I think that this got closed via this commit facebook/react-native@3ac86c3 We'll make sure to cherry pick it into 0.56.1 and release it asap. |
@kelset From what I test on RNTester , still not working. Can you verify this before publish it. |
Uhm gotcha - how did you test it? |
Exactly the same repro. Build RNTester and launch it. |
I mean, how did you text this precise fix? Did you modify the code inside your node_module? downloaded master and tested against it? |
I rebase my branch from react native master. |
@kelset I just did a fresh install of 0.56 and modified the files in my node_modules from commit facebook/react-native@3ac86c3
|
👋 thanks for the second confirmation, I've spoken with Rafeca and he told me that a colleague of his is on the case, hopefully a fix will be found soon! Anyway remember that everything is open source so you can try to pinpoint the issue yourself and create test solutions! |
@kelset In the latest code, the debug mode finally works. But you can't bundle a release using
|
@kelset , @gengjiawen : Are there any updates on how to solve the 0.56.0 problem? |
We've opened a new issue to discuss the whole Windows problem, please keep an eye there: facebook/react-native#20353 |
This is what I did and it solved the issue for me: Create a projectreact-native init awesomeproject Remove default version of RN and install v 0.55.4npm remove --save react-native Remove Metro core (not sure this is needed)npm remove --save-dev metro metro-core Remove Babel and install v 2.1.0npm remove babel-preset-react-native In the ".babelrc" file in the projectchange: "presets": ["module:metro-react-native-babel-preset"] Try to runreact-native run-android Hope it helps! John |
This is no longer a problem under 0.57. |
i am still facing this problem on 0.57.2 ... |
I have the same problem on 0.57.2 but 0.57.1 works fine on Windows |
Try 0.57.3 |
doesn't work even on 0.57.4, as in facebook/react-native#20460 |
any feasible solution? |
1 similar comment
any feasible solution? |
Babel runtime dev dependency missing npm install @babel/runtime --save-dev |
Does not work for me. |
I found a solution that worked for me for the error It seems like using a function in the |
Repro repo: https://github.com/gengjiawen/react-native/tree/feature/RNTester_start.
I am trying to make RNTester work on windows, but I am failing with the following mistake. I tested on mac, it works.
The text was updated successfully, but these errors were encountered: