0.56.x Discussion

[grabbou]

Please report any major issues and commits to cherry-pick in this thread for discussion.

[iRoachie]

Could we get this in? facebook/react-native@7469458

[grabbou]

It's not yet cut, so everything in master lands into it.

[Titozzz]

Does this means we will get babel 7 in 0.56 ♥️ 🎉 ?

[grabbou]

Not really. I am probably going to cut 0.56 before Babel 7 change as it still needs some fixes to get master green. We will do it for the 0.57 I guess.

…

On Mon, 23 Apr 2018 at 12:18 Thibault Malbranche ***@***.***> wrote: Does this means we will get babel 7 in 0.56 ♥️ 🎉 ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxvE8kaHFQtjVkQZ1TiE0RE58GHV8ks5trappgaJpZM4TFPgN> .

[Titozzz]

Oh well, I guess I'll wait one more then. Can't wait for this ! Babel 7 is finally coming. 🎉

[grabbou]

This will get addressed at some point since Facebook and other companies are also using React Native. Don't be worried. Unfortunately, this thread is not the right place to discuss it. But you have my word it's being worked on.

…

On Mon, 14 May 2018 at 11:42 MarkOSullivan94 ***@***.***> wrote: Can we please get this sorted ASAP? facebook/react-native#18095 <facebook/react-native#18095> Don't want to see a lot of RN projects unable to update their Android apps on the store in Nov 2018. Or new projects not being able to publish their apps in August 2018. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxqU3RbBCsnhFobV4URyKnLFQ2Qagks5tyVF1gaJpZM4TFPgN> .

[Titozzz]

I guess it will be nice for react-native to update @MarkOSullivan94 but I'm already using both sdk 26 and gradle 3.0 without issue on production, please tell me if I can help.

[turnrye]

Work is taking place to get master back to a stable state. There are multiple efforts presently underway for this. I suspect that late next week, RC activities will pick up.

[grabbou]

Yup, currently Hector from Facebook (@hramos) is leading internal efforts on making the CI green again. We will use this thread to notify every one of the progress (if any).

I also hope that CI gets green soon and next RC gets released, but given that we are slowly approaching an end of this month, I'll be looking at the beginning of June as a potential time for next RC.

[rawrmaan]

Would love to know more about the RN Fabric efforts going into this release. I can't seem to find any information about Fabric, its advantages, roadmap, etc.

[grabbou]

Please keep this thread related to commits that are already merged to React Native master. Meanwhile, if you need any additional help in the main React Native repo, feel free to ping me or Hector.

[kelset]

A couple of commits I'd like to see in this release:

• facebook/react-native@41975f7 (fix for some weird GBoard interactions with textinput)
• facebook/react-native@122b379 (blob memory leak)

[rawrmaan]

Got a little bit of clarity on Fabric: https://twitter.com/dan_abramov/status/1003395928831791104

[grabbou]

Sure, that sounds like a good idea.

…

On Tue, 26 Jun 2018 at 20:05 Héctor Ramos ***@***.***> wrote: Thanks @grabbou <https://github.com/grabbou> for cherry picking all of these. 0.56 is scheduled to hit stable next Monday (first business day in July). After this last RC is cut, I think we should focus our attention on release-blocking issues such as #19827. Please cc me on any PR that attempts to fix #19827. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxnjAx_mp1UAf3xNaI21FZPvpqiddks5uAnfSgaJpZM4TFPgN> .

[gnprice]

EXTRA: I think we should try to get this merged and cherry picked: facebook/react-native#19645

After some deeper debugging of the issue today, that's now a simple one-line bugfix, where the original was a revert of a previous commit that added a feature. So hopefully that now makes it easy to include!

[dulmandakh]

please cherry-pick facebook/react-native@77a02c0, so we can remove ReactFragmentActivity and do some code cleanup in 0.57.

[kelset]

Looks like we are getting really close to a stable release in time for the deadline :)

Aside from the commit proposed by @dulmandakh (that deserves mad props for all the PRs he submitted in order to improve the Android support!) I think we would need a couple more:

• facebook/react-native@bc2f12c upgrading Jest for bugfix
• facebook/react-native@b5fca80
• facebook/react-native@5017b86 @gnprice commit 🚀
• facebook/react-native@0a3055d (this is actually conceptually pretty good to have since it "enforces" a bit of better practise for Android settings)
• facebook/react-native@569061d (them warnings 🙈)

And I guess we need to keep an eye on #19827 hoping a fix is found soon.

[hramos]

Note to whoever cherry picks these, when adding facebook/react-native@5017b86 to the changelog, please use the updated description (see my comment there).

[dulmandakh]

Fix for FlatList with ListHeaderComponent facebook/react-native@dbc2346

[ikesyo]

I want facebook/react-native@75a0273 to be cherry-picked.

[futuun]

those 3 commits are fixing issues with Xcode 10, would be nice to have them:
facebook/react-native@75a0273 (for fishhook import)
facebook/react-native@e131fff (for missing config.h in glog)
facebook/react-native@a130239 (for opening invalid simulator (or no simulator at all if you have only xcode beta))

[kelset]

👋 everyone, sorry for keeping you wait; quick update regarding 0.56.0.

Since there are still a couple of open issues related to rc versions that may be "important" issues we are running some more tests updates on real world apps to make sure that it is possible to update to rc.4 and build both iOS/Android and Debug/Release.

Once we made sure that there are positive outcomes, we will release 0.56.0 with prob an extra line or two in both the changelog and the blogpost (that will be published after the npm publish) regarding these issues, in order to hopefully "increase the surface" of developers using the new version and eventually lead to a faster solution for them in 0.56.1.

[SudoPlz]

@kelset Any rough ETA ?? (are we hours, days or weeks away from release?)

[kelset]

Hopefully hours. I've tested tested with 3 different repos(debug/release, ios/Android), and the update worked on all these 3 scenarios :

• one of our own prod apps
• plain test app from 0.55.4 to 0.56.rc4 (and uploaded the repo here https://github.com/kelset/rn56-testupdate )
• another more complex test app with modules-export, .android/.ios files

and submitted a couple of PRs.
Now other devs in the core will review and approve/discuss and hopefully we can release 0.56.0.

Sadly it won't be as perfect as we'd like, but we need to keep moving forward IMHO.

[rozele]

Can we cherry-pick facebook/react-native@5494274 to allow react-native-windows to work with 0.56?

[hramos]

All of the cherry-picks requested above have been added to the 0.56-stable branch and should be released as part of 0.56.0-rc.5. This is the final RC and no further commits will be cherry-picked unless a regression was introduced between rc.4 and rc.5 - we need to promote to stable at some point so we can get moving along.

[hramos]

react-native@0.56.0-rc.5 is out, @rozele, @futuun, @ikesyo, @gnprice, @dulmandakh please take a look and let us know if we can promote rc.5 to become the final, stable 0.56 release 🚀🎉

[dulmandakh]

Upgraded 2 projects from 0.55.4 to 0.56.0-rc.5 just fine. On iOS, got React Native version mismatch error and had to open XCode, then run Product -> Clean to fix it. On Android, resolved few conflicts due to changes in gradle files.

[lebedev]

@dulmandakh How did you upgrade, btw? With react-native-git-upgrade? Or just by specifying newer version in package.json?

[dulmandakh]

@angly-cat react-native-git-upgrade next

[kelset]

0.56.0 has been released

Any future conversation on this thread will be limited to backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.56.0 cut. For new features that you would like to see implemented, refer to #34

If you cannot point to a particular commit on master, then your "bug fix request" likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[kelset]

For 0.56.1 we should aim (IMHO) to release as soon as this is fixed fully: facebook/react-native#19953 (and facebook/metro#181)

Currently it seems that a fix has been merged in master: facebook/react-native@3ac86c3

but there has been a report that is actually still not fixed (sadly). So prob cherry picking that is a start but something else will be required.

[janicduplessis]

Would be nice to include facebook/react-native@b4b594c if we do a patch release, it fixes a regression with TextInput.State.currentlyFocusedField.

[hramos]

It looks like that commit can be applied cleanly on top of 0.56. If you have push access, you can try cherry-picking it onto 0.56-stable and running the bump-version script to tag a new patch release.

[grabbou]

Just did that before we make 0.57 stable (for some reason it doesn't work properly when we release a patch to non-latest release).

Anyway, impressed we didn't have much to cherry-pick and release since then.

[grabbou]

Closing as 0.57.0 has just hit npm. No future cherry-picks will be accepted unless a security/critical issue arises in the meantime.