0.57.0 Discussion

[grabbou]

Conversation on this thread are limited to 0.57 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[kelset]

Before we reach 0.57.0 we need to be sure this is fixed/closed: facebook/react-native#20327

During RC phase should be enough to change the preset dep

  - "presets": [ "react-native" ],
  + "presets": [ "metro-react-native-babel-preset" ],

But yeah we need to ensure the transition.

[Kevat]

Will this issue be resolved by 0.57:
facebook/react-native#19953

When is 0.57 due for release? It has been frustrating not being able to use react native on Windows.

[jamsch]

@kelset I believe you need to set module:metro-react-native-babel-preset if the module name isn't prefixed with "babel-preset".

Also preferably this commit should be cherry picked in to the next release, it's one of the few issues that we're having to maintain a fork for.

[kelset]

Hey thanks for the feedback - we still haven't released the first rc because we had some issues testing RNTester, so we'll basically sync the 0.57 branch with master asap so you'll also get that fix (I want it too 😅).

[rafaellincoln]

Is there any chance of this commit entering version 0.57?

[kelset]

@rafaellincoln we are cutting the first RC of 0.57 today (unless during our testing something weird happens) and we'll basically synch the branch with master first, so you'd be able to see that commit in it 💪

[fungilation]

Update on 0.57 please? I'm not seeing any RC on https://github.com/facebook/react-native/releases

[kelset]

While testing the branch we got stuck on this facebook/react-native#20567

so until we resolve it we won't release.

In the meantime you can find a draft of the changelog for the new version in the dedicated branch - it's a WIP but if you want to have a quick view of what is going to happen there you can read it.

[kelset]

Quick update, we managed - with the help of a few amazing devs of this community - to finally get to a stage where we are feeling ok with releasing the first RC.

Currently CI is blocked by an invalid npm token, but it's being taken care of so expect 0.57-rc0 to be on npm in the next 12/24 hours.

[grabbou]

While we are waiting for the npm token to be released, there's work already happening on getting the docs in place (thanks to @turnrye).

We are looking for a period of ~2 weeks before we promote RC to stable. That should give us enough time to make sure it works without any major regressions and get us back into the monthly release cycle.

Note: The release cycle is being currently discussed here

[grabbou]

React Native 0.57.0-rc.0 is out https://www.npmjs.com/package/react-native/v/0.57.0-rc.0. The docs are going to be published in a while I believe.

[fungilation]

Can't go further than react-native-git-upgrade 0.57.0-rc.0 since that's breaking for me.

Good old react-native upgrade is also broken.

facebook/react-native#20710

[kelset]

A few issues and PRs we should try to have merged (and cherry picked) for 0.57.0:

• --reset-cache options broken for React Native CLI facebook/react-native#20703 fixed via Apply --reset-cache argument to bundle command facebook/react-native#20706
• Do not override metro.config.js settings facebook/react-native#20705
• Fix regression in dynamic resolution for out-of-tree platforms facebook/react-native#20662
• we should make sure to have metro version that uses this Pass resetCache option to jest-haste-map facebook/metro#223

[danielgindi]

Is react-native published to nexus?
Because there are issues with many native libraries, with dependencies like compile 'com.facebook.react:react-native:+' - where Android Studio tries to download 0.20.1 and compile against that.

Update:
Many native modules reference maven { url "$projectDir/../node_modules/react-native/android" }, but react-native/android does not exist.

[rozele]

Once it's merged, can we cherry-pick facebook/react-native#20705 onto 0.57-stable and cut another RC for react-native-windows and react-native-dom. +@vincentriemer

[janhesters]

Will this issue #19859 (testing) be fixed in version 0.57? It feels weird for a lot of new people that testing is broken out of the box.

[grabbou]

Yes, @janhesters, this should be fixed. I already commented on that issue. Thanks for rising that - this is exactly what this issue is for.

@danielgindi, please raise your issue in RN repository itself. The RN comes always from node_modules and we never publish the Android version to any external dependency center (including Maven etc.). I believe there might be some historical versions published there, which gives you an error about the wrong version. Try installing node modules again.

@fungilation there's ongoing discussion about whether to rewrite/drop react-native-git-upgrade entirely due to its brittleness with new upgrades. Are you able to provide your feedback about it, preferably via email? (it's on my profile) We could start a proposal to create a better, new, version of it. If you feel like having enough free time, I could help you get it up and running.

[janhesters]

@grabbou Awesome news! Thank you very much.

[kelset]

Update on my previous comment:

• one of @rozele's PRs landed, so we need to cherry-pick this facebook/react-native@c5297c7 and wait for Metro 0.43.7 to be releases since this commit is not published yet facebook/metro@387d487
• until Metro 0.43.7 is released this can't be merged Apply --reset-cache argument to bundle command facebook/react-native#20706 (and cherry pick it)
• we'll also need to cherry pick this Fixes #20712 on unix-like OS facebook/react-native#20751 (context: react-native 0.57.0-rc.0 - Error: ENOENT: no such file or directory [Windows] facebook/react-native#20712 (comment) )

To answer @janhesters - if you've read my comment at the bottom in that issue, it explains how it's not a react-native issue per se. That said we may consider "removing" jest from the init template so that we can avoid this:

It feels weird for a lot of new people that testing is broken out of the box.

[rozele]

@kelset - I commented on facebook/react-native#20706. That comment does not depend on the change to metro. Metro still accepts the option for --reset-cache, the change to metro only affects the internal handling of that flag and ensures it's passed down to jest-haste-map

Edit: Also - facebook/react-native@c5297c7 is not blocked on metro either, so that can be cherry-picked ASAP so we can release an RC for react-native-windows targeting 0.57 RC.1.

[fungilation]

@grabbou I'm emailing you. But I'll say here that react-native-git-upgrade has been reliably upgrading every version for me since about 0.50 or earlier. And no doubt it's better than react-native upgrade with its 3 way merging of template files, instead of manual diffing. I'm all for a better version of react-native-git-upgrade.

[janhesters]

@kelset Yup I've read your comment and it helped me tremendously! It's a well working fix, thank you very much for that.

Why not just add that fix to the stable version of React Native? In my opinion removing jest from react-native init template would be a bad move, because having Jest shipped with React Native encourages great programming!
I always loved for example how Django also ships with testing files and has a explicit chapter about testing in it's docs.
When I first picked up React Native I was excited to see that other frameworks also animate the user to write tests. It's an amazing privilege for new programmers, when they get lead by more experienced programmers to use best practices and write long-term stable code 🔥🤓

[jamsch]

Just noticed that ReactFragmentActivity says it will be removed on the 0.57 release. Will this still be removed?

[empyrical]

I would love if this commit made it into 0.57.1:

facebook/react-native@4b106be

[hramos]

@jamsch it didn't end up getting removed. We should probably remove that comment, as we have not formalized how deprecations should be handled (as in, how many releases will we allow them to remain @deprecated before outright removing them).

[hramos]

@markharding we're only cherry-picking commits from master. That PR is still open.

[kelset]

As a rough estimate for 0.57.1, currently we are focusing on having XCode 10 working properly with RN (since they just released it, it will take a few days at least still) plus a Metro fix before releasing it.

Aside from that, please only ask for commits already merged to master - as probably we will only cut a first 0.58 rc after we release 0.57.1.

[rafeca]

The fix for Metro already landed in master (the change is only in the React Native repo).
This is the commit: facebook/react-native@7a69f1a and it would be lovely if it's cherry-picked to v0.57.1

[hramos]

Xcode fix: I nominate facebook/react-native@8103c43 for 0.57.1. That commit is in master, but did not make the cut for 0.57.0.

[hawkrives]

I'd like to nominate facebook/react-native@b9c28c2 for 0.57.1; without it, I have to // $FlowExpectedError whenever I use <TextInput scrollEnabled={false} />. (I think it's all ready to go; apologies if it's not.)

[oblador]

I’d like to nominate facebook/react-native@9fca769 to fix storybook compatibility.

[christianbach]

Perhaps facebook/react-native@d1ff0b0 is suited for the 0.57.1 release?

[kelset]

Hey everyone, the current idea is to do a small 0.57.1 before the weekend that won't fix all the Xcode 10 issues but at least give us all those nominated commits plus a couple more fixes - we just run in a Metro issue yesterday evening so we are waiting for a new release of that before proceeding.

[kelset]

Update: since Metro 0.45.6 has been released and works great, I've tested locally this set of cherry picks (in order of picking):

• Expose scrollEnabled as iOS prop for TextInput
• fix RCTNetInfo first time connection status
• Give RNPM the ability to look for plugins in @Scoped modules
• Making RCTIsIPhoneX() return true for the R and Max models
• Upgrade babel-eslint to 9.0.0
• Pass the maxWorkers config param correctly to Metro
• Fix ignored --projectRoot/watchFolders arguments
• Expose AllowFileAccess property in WebView
• Way to register RCT_MODULE in Plugin2.0 instead of +load
• Debug only code were leaking into release builds on iOS
• Update RCTLinkingManager.h to explicitly state the 'nullability' of parameters

Plus, on top, the commit to "enforce" the newer metro Bump metro@0.45.6 (which caused a conflict, I think because I haven't cherry picked the other 3/4 commits that bump the minor version - I just solved it locally).

With this "local set" of commits on top of 0.57-stable all my tests were ✅

I'm just waiting for the approval from other maintainers then we can proceed to release 0.57.1.

---

Minor notes on a couple more commits:

• for some reason didn't manage to cherry pick Fix TextInput.setNativeProps({text: ''}) to work - not sure why
• the Xcode related commit Removing development team from Xcode project. caused conflicts that I couldn't fix even by importing earlier commits like Dynamically load WebKit and Implement 'dataDetectorTypes' prop, so I gave up. But should not too big of a deal since it wasn't a "all mighty fix" for Xcode 10 anyway.

[mjmasn]

If there's going to be a 0.57.2 it would be awesome to get these two fixes for scroll views in:
facebook/react-native@e0170a9
facebook/react-native@4af4da9

[sunnylqm]

Please include this fix in 0.57.2 facebook/react-native@1323acd

[kelset]

Hey folks, since with the core we agreed that 0.57.x is a fairly stable release and that we are waiting on a few things from FB internal codebase to land to the OSS for 0.58, we decided to "extend" the lifespan of 0.57.

For this reason, I've opened a new issue for version 0.57.1 (latest currently) to which suggest cherry picks. And similarly when 0.57.2 will be released we'll do the same.