Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--reset-cache options broken for React Native CLI #20703

Closed
3 tasks done
rozele opened this issue Aug 17, 2018 · 0 comments
Closed
3 tasks done

--reset-cache options broken for React Native CLI #20703

rozele opened this issue Aug 17, 2018 · 0 comments
Labels
Platform: Windows Building on Windows. Resolution: Locked This issue was locked by the bot. Resolution: PR Submitted A pull request with a fix has been provided. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used.

Comments

@rozele
Copy link
Contributor

rozele commented Aug 17, 2018 •
edited by hramos
Loading

Environment

[skip envinfo]

Description

Describe your issue in detail. Include screenshots if needed. If this is a regression, let us know.

--reset-cache does not remove the metro-cache, metro-cache-* or haste-map-metro-* files/folders on Windows.

Reproducible Demo

Let us know how to reproduce the issue. Include a code sample, share a project, or share an app that reproduces the issue using https://snack.expo.io/. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve

  1. Run react-native bundle command
  2. Open %LOCALAPPDATA%/Temp
  3. See cache files matching patterns created
  4. Run --reset-cache
  5. See cache files were not updated.
@rozele rozele mentioned this issue Aug 17, 2018
Closed
@kelset kelset added Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used. 📋No Environment Info and removed Core Team labels Aug 17, 2018
@kelset kelset mentioned this issue Aug 17, 2018
Closed
@hramos hramos added Platform: Windows Building on Windows. Resolution: PR Submitted A pull request with a fix has been provided. and removed 📋No Environment Info labels Aug 17, 2018
kelset pushed a commit that referenced this issue Aug 22, 2018
@rozele @kelset
Apply --reset-cache argument to bundle command (#20706)
e90d9ca 
Summary:
The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro.

Fixes #20703

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull Request resolved: #20706

Differential Revision: D9400548

Pulled By: hramos

fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
aleclarson pushed a commit to aleclarson/react-native that referenced this issue Sep 16, 2018
@rozele @aleclarson
Apply --reset-cache argument to bundle command (facebook#20706)
1b2d766 
Summary:
The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro.

Fixes facebook#20703

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull Request resolved: facebook#20706

Differential Revision: D9400548

Pulled By: hramos

fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
t-nanava pushed a commit to microsoft/react-native-macos that referenced this issue Jun 17, 2019
@rozele @facebook-github-bot
Apply --reset-cache argument to bundle command (facebook#20706)
187e1cf 
Summary:
The `--reset-cache` argument was not working correctly with the `bundle` command. This ensures the `--reset-cache` arg is passed to metro.

Fixes facebook#20703

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull Request resolved: facebook#20706

Differential Revision: D9400548

Pulled By: hramos

fbshipit-source-id: 2c7ed0226cfcdffa8cc77506500c314552baef3f
@facebook facebook locked as resolved and limited conversation to collaborators Aug 20, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Platform: Windows Building on Windows. Resolution: Locked This issue was locked by the bot. Resolution: PR Submitted A pull request with a fix has been provided. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply --reset-cache argument to bundle command
4 participants
@hramos @rozele @kelset @react-native-bot