Implement require.unstable_importMaybeSync and use it in JSResource #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
rubennorte
added a commit
to rubennorte/metro
that referenced
this pull request
Jun 21, 2024
…acebook#1296) Summary: Pull Request resolved: facebook#1296 This implements `require.unstable_importMaybeSync`, a new API to avoid having to wait for the next tick when importing a value using dynamic `import()` in bundles that don't use bundle splitting. This API behaves this way: * If the app is using bundle splitting, `require.unstable_importMaybeSync()` behaves exactly like `import()`. It always returns a promise and it marks a split point for the bundle. * If the app isn't using bundle splitting, it behaves like a static import (e.g.: `import * as module from 'module'`) and returns the exports for that module synchronously. This isn't meant to be used by users directly but to build other more specific APIs on top of this. It includes a small refactor to `asyncRequire.js`. Differential Revision: D58873729
rubennorte
force-pushed
the
export-D58873729
branch
from
8e916ac
to
110fade
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
rubennorte
added a commit
to rubennorte/metro
that referenced
this pull request
Jun 21, 2024
…acebook#1296) Summary: Pull Request resolved: facebook#1296 This implements `require.unstable_importMaybeSync`, a new API to avoid having to wait for the next tick when importing a value using dynamic `import()` in bundles that don't use bundle splitting. This API behaves this way: * If the app is using bundle splitting, `require.unstable_importMaybeSync()` behaves exactly like `import()`. It always returns a promise and it marks a split point for the bundle. * If the app isn't using bundle splitting, it behaves like a static import (e.g.: `import * as module from 'module'`) and returns the exports for that module synchronously. This isn't meant to be used by users directly but to build other more specific APIs on top of this. It includes a small refactor to `asyncRequire.js`. Differential Revision: D58873729
rubennorte
force-pushed
the
export-D58873729
branch
from
110fade
to
7a6e57c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 83.83% 83.83% -0.01%
==========================================
Files 207 207
Lines 10847 10880 +33
Branches 2716 2731 +15
==========================================
+ Hits 9094 9121 +27
- Misses 1753 1759 +6 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
rubennorte
added a commit
to rubennorte/metro
that referenced
this pull request
Jun 21, 2024
…acebook#1296) Summary: Pull Request resolved: facebook#1296 This implements `require.unstable_importMaybeSync`, a new API to avoid having to wait for the next tick when importing a value using dynamic `import()` in bundles that don't use bundle splitting. This API behaves this way: * If the app is using bundle splitting, `require.unstable_importMaybeSync()` behaves exactly like `import()`. It always returns a promise and it marks a split point for the bundle. * If the app isn't using bundle splitting, it behaves like a static import (e.g.: `import * as module from 'module'`) and returns the exports for that module synchronously. This isn't meant to be used by users directly but to build other more specific APIs on top of this. It includes a small refactor to `asyncRequire.js`. Differential Revision: D58873729
rubennorte
force-pushed
the
export-D58873729
branch
from
7a6e57c
to
c2e3f20
Compare
rubennorte
added a commit
to rubennorte/metro
that referenced
this pull request
Jun 24, 2024
…acebook#1296) Summary: Pull Request resolved: facebook#1296 This implements `require.unstable_importMaybeSync`, a new API to avoid having to wait for the next tick when importing a value using dynamic `import()` in bundles that don't use bundle splitting. This API behaves this way: * If the app is using bundle splitting, `require.unstable_importMaybeSync()` behaves exactly like `import()`. It always returns a promise and it marks a split point for the bundle. * If the app isn't using bundle splitting, it behaves like a static import (e.g.: `import * as module from 'module'`) and returns the exports for that module synchronously. This isn't meant to be used by users directly but to build other more specific APIs on top of this. It includes a small refactor to `asyncRequire.js`. Reviewed By: motiz88 Differential Revision: D58873729
rubennorte
force-pushed
the
export-D58873729
branch
from
c2e3f20
to
7d8d5e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
rubennorte
force-pushed
the
export-D58873729
branch
from
7d8d5e4
to
0f0c6de
Compare
rubennorte
added a commit
to rubennorte/metro
that referenced
this pull request
Jun 24, 2024
…acebook#1296) Summary: Pull Request resolved: facebook#1296 This implements `require.unstable_importMaybeSync`, a new API to avoid having to wait for the next tick when importing a value using dynamic `import()` in bundles that don't use bundle splitting. This API behaves this way: * If the app is using bundle splitting, `require.unstable_importMaybeSync()` behaves exactly like `import()`. It always returns a promise and it marks a split point for the bundle. * If the app isn't using bundle splitting, it behaves like a static import (e.g.: `import * as module from 'module'`) and returns the exports for that module synchronously. This isn't meant to be used by users directly but to build other more specific APIs on top of this. It includes a small refactor to `asyncRequire.js`. Reviewed By: motiz88 Differential Revision: D58873729
…acebook#1296) Summary: Pull Request resolved: facebook#1296 This implements `require.unstable_importMaybeSync`, a new API to avoid having to wait for the next tick when importing a value using dynamic `import()` in bundles that don't use bundle splitting. This API behaves this way: * If the app is using bundle splitting, `require.unstable_importMaybeSync()` behaves exactly like `import()`. It always returns a promise and it marks a split point for the bundle. * If the app isn't using bundle splitting, it behaves like a static import (e.g.: `import * as module from 'module'`) and returns the exports for that module synchronously. This isn't meant to be used by users directly but to build other more specific APIs on top of this. It includes a small refactor to `asyncRequire.js`. Reviewed By: motiz88 Differential Revision: D58873729
|
This pull request was exported from Phabricator. Differential Revision: D58873729 |
rubennorte
force-pushed
the
export-D58873729
branch
from
0f0c6de
to
86ecf52
Compare
|
This pull request has been merged in 7b2ca5e. |
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Aug 1, 2024
…e it in JSResource (#30703) # Why - Mirror feature from metro facebook/metro#1296 # Test Plan - Pulled in upstream tests. - Tree shaking tests should also continue to work. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
amandeepmittal
pushed a commit
to expo/expo
that referenced
this pull request
Aug 5, 2024
…e it in JSResource (#30703) # Why - Mirror feature from metro facebook/metro#1296 # Test Plan - Pulled in upstream tests. - Tree shaking tests should also continue to work. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This implements
require.unstable_importMaybeSync, a new API to avoid having to wait for the next tick when importing a value using dynamicimport()in bundles that don't use bundle splitting.This API behaves this way:
require.unstable_importMaybeSync()behaves exactly likeimport(). It always returns a promise and it marks a split point for the bundle.import * as module from 'module') and returns the exports for that module synchronously.This isn't meant to be used by users directly but to build other more specific APIs on top of this.
It includes a small refactor to
asyncRequire.js.Differential Revision: D58873729