Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump jest-haste-map et al #445

Closed
wants to merge 1 commit into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Aug 20, 2019

Summary

Bumping jest-haste-map and all related Jest packages btw to 24.9, so that this patch is applied. I know it's in the semver range, but doing so will invalidate lockfiles of React Native users, whose Metro is transitive dependency of.

Hopefully we can get this in 0.56 release :)

Test plan

CI passes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files         191      191           
  Lines        6285     6285           
  Branches      996      996           
=======================================
  Hits         5352     5352           
  Misses        839      839           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebcdf4...ab22b03. Read the comment docs.

@cpojer
Copy link
Contributor

cpojer commented Aug 21, 2019

Unfortunately we cannot merge this because Metro is entangled with all other RN stuff at FB. It will need to be updated in a single commit across all projects at once. cc @scotthovestadt

@mikehardy
Copy link
Contributor

Note that of the two issues I've had to patch-package for jest-haste-map one is fixed but the other (jestjs/jest#8558) - which was released as 24.8.1 still just does not come down in a react-native 0.60.5 environment by default for some reason. I understand this might be a dependency mess internally but I would ❤️ for this to be done for RN0.61. Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants