Added bundler property to babel caller #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`name` is used in Webpack for `babel-loader` but certain tools use custom babel loaders which makes the `name` field an unpredictable way for detecting what bundler is being used. Adding a bundler property to every loader will help make this more distinguishable.
facebook-github-bot
added
the
CLA Signed
cpojer
approved these changes
May 15, 2020
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced May 31, 2021
Closed
Open
fix(deps): update dependency metro-react-native-babel-preset to v0.77.0
write-for-CHRIST/vichurch#35
Open
Open
Open
This was referenced Jun 6, 2021
Update dependency metro-react-native-babel-preset to v0.77.0
ManAnRuck/document-management-system#21
Open
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nameis set tobabel-loaderin Webpack but certain tools use custom babel loaders which makes thenamefield an unpredictable property for detecting what bundler is being used.Adding a bundler property to every loader will help make this more distinguishable.
Expo currently does this in the
@expo/webpack-config(here) as a way of configuring the babel preset to tree-shake unusedreact-native-webcode.We'd like to move away from using
babel-loaderin favor of using this newbundlerproperty so more free form configurations like "Metro + react-native-web" can be easily configurable expo/expo#8170