-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README with client and server commands #13
Conversation
Update README echo server sample commands. The IPv6 localhost address `::1` was added on the client and the `-host` argument was removed on the server because this is the default address by default.
Relates to issue #11 |
While you are at it, can you propagate the |
I will start looking into that. Upon completion that will require an update to the |
@udippant This PR has been updated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Thank you! We will review it internally and merge it back. |
Is there any action needed from me on this PR at this time? |
@agnosticdev I have merged it back. Thank you for contributing. |
Thank you @udippant ! |
) Summary: Take the README.md from https://github.com/facebookexperimental/mononoke/blob/7ead0e29e41aec0771531a4650b6170bc1ff6566/README.md and apply it on Eden repo. Re-add the Cargo.toml file that declares Cargo workspace. Re-add fbcode_builder/getdeps manifest for Mononoke Pull Request resolved: facebook/sapling#13 Test Plan: ./build/fbcode_builder/getdeps.py build mononoke ./build/fbcode_builder/getdeps.py test mononoke Reviewed By: ahornby Differential Revision: D19833059 Pulled By: lukaspiatkowski fbshipit-source-id: fb37e13306c0b9969a7c4e52b05e1a66a577022f
Update README echo server sample commands.
The IPv6 localhost address
::1
was added on the client and the-host
argument was removed on the server because this is the default address by default.