Decouple fizz:test::MockAead from MockAead. Use the former for code that actually needs fizz. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
deadalnix
changed the title
There was a problem hiding this comment.
@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
deadalnix
force-pushed
the
fizzdecouplemockaead
branch
from
7b0337d
to
3c3f65e
Compare
There was a problem hiding this comment.
@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2019
…codebase fizz agnostic. (#16) Summary: This is based on top of #15 . Now that the codebase have been refactored to use Aead/fizz:Aead and MockAead/fizz::test::MockAead in proper places, it is time to ensures the aren't aliases of each others anymore. This introduces FizzAead as a wrapper for fizz::Aead that implements quic::Aead and forward all calls. Most of the codebase now uses quic::Aead, which a significant step toward being able to swap it for another implementation. Pull Request resolved: #16 Reviewed By: yangchi Differential Revision: D15474068 Pulled By: mjoras fbshipit-source-id: 7cccc9909a45ea538409645644641e39a58bf81d
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #12 .
It logically split MockAead and fizz::MockAead in preparation for separation of the two.