Generate report if nullptr #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yangchi
suggested changes
Jun 27, 2019
| @@ -88,6 +88,7 @@ PacketNumEncodingResult encodeLongHeaderHelper( | |||
| appender.push(originalDstConnId->data(), originalDstConnId->size()); | |||
|
|
|||
| // Write the retry token | |||
| assert(token && "token is nullptr"); | |||
There was a problem hiding this comment.
CHECK(token) << "Empty token";
aditya7fb
force-pushed
the
export-D16005649
branch
from
55c02af to
e5ba22e
Compare
aditya7fb
added a commit
to aditya7fb/mvfst
that referenced
this pull request
Jun 27, 2019
Summary: Pull Request resolved: facebook#25 Reviewed By: sharma95 Differential Revision: D16005649 fbshipit-source-id: abf65bff94e4253ca480d2a747b108de4dfc1caa
Summary: Pull Request resolved: facebook#25 Reviewed By: sharma95 Differential Revision: D16005649 fbshipit-source-id: cfed6142766cd39a3035a7dcec625717ceb336c7
aditya7fb
force-pushed
the
export-D16005649
branch
from
e5ba22e to
0a496ce
Compare
|
This pull request has been merged in 34d8f6b. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2020
…eps (#25) Summary: Fixes include: 1. Passing "GETDEPS_BUILD_DIR" and "GETDEPS_INSTALL_DIR" env variable and using them in eden/scm/Makefile rather than assuming the source code is always in the same place regardless getdeps arguments (it isn't). 2. Added "fbthrift-source" and "fb303-source" to avoid unnecessary compilation (at least of fb303) and to put fbthrift and fb303 source code in an easy to locate place inside getdeps' "installed" folder. Pull Request resolved: facebook/sapling#25 Test Plan: sandcastle, check oss-eden_scm-darwin-getdeps Reviewed By: farnz Differential Revision: D22431872 Pulled By: lukaspiatkowski fbshipit-source-id: 8ccbb090713ec085a5dd56df509eb58ab6fb9e34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D16005649