Fix merge_small_tests-t, merge_large_tests-t, and routertest_component_bootstrap #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…t_bootstrap Fix unit tests after merging facebook@3847e40e2641 and facebook@9e2db8e1c0db Changes: 1. Allow `MDL_context::acquire_lock_nsec` to work with `thd == nullptr` 2. Remove an upstream hack in `Test_MDL_context_owner::get_thd` that returns `(THD *)1` 3. Update error code for `BootstrapFailWhenServerResponseExceedsReadTimeout` 4. Fix `Mysys.CreateTempFile` when access to `/tmp` is denied
|
@inikep has updated the pull request. Re-import the pull request |
|
I've updated this patch with added a fix for |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Dec 20, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 27, 2019
…t_bootstrap (#1067) Summary: Fix unit tests after merging 3847e40e2641 and 9e2db8e1c0db Changes: 1. Allow `MDL_context::acquire_lock_nsec` to work with `thd == nullptr` 2. Remove an upstream hack in `Test_MDL_context_owner::get_thd` that returns `(THD *)1` 3. Update error code for `BootstrapFailWhenServerResponseExceedsReadTimeout` 4. Fix `Mysys.CreateTempFile` when access to `/tmp` is denied Squash with D14652380, D7298713, D16421520 Pull Request resolved: #1067 Reviewed By: lth Differential Revision: D19129729 Pulled By: lth fbshipit-source-id: 61b1a9d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 27, 2020
…t_bootstrap (facebook#1067) Summary: Fix unit tests after merging 3847e40 and 9e2db8e Changes: 1. Update error code for `BootstrapFailWhenServerResponseExceedsReadTimeout` 2. Fix `Mysys.CreateTempFile` when access to `/tmp` is denied Pull Request resolved: facebook#1067 Reviewed By: lth Differential Revision: D19129729 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unit tests after merging 3847e40e2641 and 9e2db8e1c0db
Changes:
MDL_context::acquire_lock_nsecto work withthd == nullptrTest_MDL_context_owner::get_thdthat returns(THD *)1BootstrapFailWhenServerResponseExceedsReadTimeoutMysys.CreateTempFilewhen access to/tmpis denied