New status variable gtid_committed to denote trxs committed to storage engine #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e engine Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. Originally Reviewed By: anirbanr-fb fbshipit-source-id: fbde38d 8.0 porting notes: Since 10e7902, master waits for the reply from a semi-sync slave, and only then updates 'gtid_executed'. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable.
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2020
…e engine (#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: 14fdbb5004b Pull Request resolved: #1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 3, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
…e engine (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lth Differential Revision: D20121951 Pulled By: abhinav04sharma fbshipit-source-id: 8232ea7
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 11, 2021
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 (facebook@86ccfd0) Pulled By: abhinav04sharma fbshipit-source-id: 15620ae74fe
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2021
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 (facebook@86ccfd0) Pulled By: abhinav04sharma fbshipit-source-id: 15620ae74fe
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2021
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 (facebook@86ccfd0) Pulled By: abhinav04sharma fbshipit-source-id: 15620ae74fe
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 (facebook@86ccfd0) Pulled By: abhinav04sharma fbshipit-source-id: 15620ae74fe
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 18, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 19, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 20, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 24, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 28, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 28, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 8, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 9, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 11, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 14, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 14, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 15, 2022
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…e engine (facebook#1110) (facebook#1110) Summary: Gtid_executed can give a false sense of how many transactions are committed because it's updated after they are written to the binlog. There are scenarios where there might be a significant delay between write to binlog and commit in the storage engine, like while using semi-sync protocol. This change introduces another status variable gtid_committed that is updated after storage engine commit. 8.0 porting notes: gtid_executed is now updated at the end of group commit. That makes 'gtid_executed' what 'gtid_committed' was designed to be. That's why this patch adds 'gtid_committed' as an alias for the existing 'gtid_executed' variable. Reference Patch: facebook@14fdbb5004b Pull Request resolved: facebook#1110 Reviewed By: lloyd Differential Revision: D20121951 Pulled By: abhinav04sharma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gtid_executed can give a false sense of how many transactions are
committed because it's updated after they are written to the binlog. There are
scenarios where there might be a significant delay between write to binlog and
commit in the storage engine, like while using semi-sync protocol. This change
introduces another status variable gtid_committed that is updated after storage
engine commit.
Originally Reviewed By: anirbanr-fb
fbshipit-source-id: fbde38d
8.0 porting notes:
Since 10e7902, master waits for the reply from a semi-sync slave, and
only then updates 'gtid_executed'. That makes 'gtid_executed' what
'gtid_committed' was designed to be. That's why this patch adds
'gtid_committed' as an alias for the existing 'gtid_executed' variable.