Copy and move index file only when there are changes #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When index file is updated, it is first copied to a crash safe index file, updates are made to the crash safe file and finally the crash safe file is renamed. During purge, all this should happen only when at least one log is being removed. Test Plan: Checked if all existing test cases pass
|
@abhinav04sharma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
abhinav04sharma
added a commit
to abhinav04sharma/mysql-5.6
that referenced
this pull request
Dec 6, 2016
Summary: When index file is updated, it is first copied to a crash safe index file, updates are made to the crash safe file and finally the crash safe file is renamed. During purge, all this should happen only when at least one log is being removed. Closes facebook#434 Github Author: Abhinav Sharma <abhinavsharma@fb.com> Github PR Sync: {sync, type="child", parent="github", parentrepo="facebook/mysql-5.6", parentprnum="434", parentprfbid="171820066615445"} Test Plan: Checked if all existing test cases pass Reviewers: herman, santoshb, svcscm Reviewed By: santoshb, svcscm Subscribers: svcscm, webscalesql-eng@ Differential Revision: https://phabricator.intern.facebook.com/D4198759 Tasks: 13668299 Signature: t1:4198759:1479408838:1696fa31943f1db04e284baed289e0db33ad5a19
hermanlee
pushed a commit
that referenced
this pull request
Jan 31, 2017
Summary: When index file is updated, it is first copied to a crash safe index file, updates are made to the crash safe file and finally the crash safe file is renamed. During purge, all this should happen only when at least one log is being removed. Closes #434 Reviewed By: santoshbanda Differential Revision: D4198759 Pulled By: abhinav04sharma fbshipit-source-id: 90a1d5c
VitaliyLi
pushed a commit
to VitaliyLi/mysql-5.6
that referenced
this pull request
Feb 9, 2017
Summary: When index file is updated, it is first copied to a crash safe index file, updates are made to the crash safe file and finally the crash safe file is renamed. During purge, all this should happen only when at least one log is being removed. Closes facebook#434 Reviewed By: santoshbanda Differential Revision: D4198759 Pulled By: abhinav04sharma fbshipit-source-id: 90a1d5c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Feb 7, 2019
Jira ticket: https://jira.percona.com/browse/FB8-85 Reference Patch: facebook@4a1823a Can be squashed with FB8-77 `Changed the behavior of purging logs. Now deleting logs first and then updating the index.`: https://jira.percona.com/browse/FB8-77 facebook@97ae20b Summary: When index file is updated, it is first copied to a crash safe index file, updates are made to the crash safe file and finally the crash safe file is renamed. During purge, all this should happen only when at least one log is being removed. Closes facebook#434 Originally Reviewed By: santoshbanda Pulled By: abhinav04sharma fbshipit-source-id: 90a1d5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When index file is updated, it is first copied to a crash safe index
file, updates are made to the crash safe file and finally the crash safe file is
renamed. During purge, all this should happen only when at least one log is
being removed.
Test Plan: Checked if all existing test cases pass