Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #802: MyRocks: Statement rollback doesnt work correctly for nes… #804

Closed
wants to merge 2 commits into from
Closed

Issue #802: MyRocks: Statement rollback doesnt work correctly for nes… #804

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612ec75
Issue #802: MyRocks: Statement rollback doesnt work correctly for nes…
spetrunia Apr 5, 2018
c90fbbc
Issue #802: MyRocks: Statement rollback doesnt work correctly for nes…
spetrunia Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions storage/rocksdb/ha_rocksdb.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2409,6 +2409,17 @@ class Rdb_transaction {
virtual void start_tx() = 0;
virtual void start_stmt() = 0;

void set_initial_savepoint() {
/*
Set the initial savepoint. If the first statement in the transaction
fails, we need something to roll back to, without rolling back the
entire transaction.
*/
do_set_savepoint();
m_n_savepoints= 1;
m_writes_at_last_savepoint= m_write_count;
}

/*
Called when a "top-level" statement inside a transaction completes
successfully and its changes become part of the transaction's changes.
Expand Down Expand Up @@ -2767,12 +2778,7 @@ class Rdb_transaction_impl : public Rdb_transaction {

m_read_opts = rocksdb::ReadOptions();

/*
Set the initial savepoint. If the first statement in the transaction
fails, we need something to roll back to, without rolling back the
entire transaction.
*/
do_set_savepoint();
set_initial_savepoint();

m_ddl_transaction = false;
}
Expand Down Expand Up @@ -3013,12 +3019,7 @@ class Rdb_writebatch_impl : public Rdb_transaction {
write_opts.ignore_missing_column_families =
THDVAR(m_thd, write_ignore_missing_column_families);

/*
Set the initial savepoint. If the first statement in the transaction
fails, we need something to roll back to, without rolling back the
entire transaction.
*/
do_set_savepoint();
set_initial_savepoint();
}

void start_stmt() override {}
Expand Down