FB8-49: Don't remove padding chars for binary column in RBR #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
requested changes
Feb 6, 2019
There was a problem hiding this comment.
I think there's a number of tests failing, but it's not clear to me if all of them just need to be re-recorded, or if something else is going on.
main.mysqlbinlog_rbr_column_names
binlog_nogtid.binlog_mysqlbinlog_row
binlog_nogtid.binlog_mysqlbinlog_row_myisam
binlog_nogtid.binlog_mysqlbinlog_row_innodb
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
lth
reviewed
Feb 8, 2019
| @@ -6324,8 +6324,10 @@ uchar *Field_string::pack(uchar *to, const uchar *from, uint max_length, | |||
| (this is for not packing padding adding bytes in BINARY | |||
| fields). | |||
| */ | |||
| if (field_charset->mbmaxlen == 1) { | |||
| while (length && from[length - 1] == field_charset->pad_char) length--; | |||
| if (key_type() != HA_KEYTYPE_BINARY) { | |||
There was a problem hiding this comment.
I don't think the body of this if statement is correct. It should both the mbmaxlen == 1 case and the else statement.
You can see that the re-recorded results are actually incorrect, because we're spacing padding varchars. This is because we're now keeping padding characters for charsets with mbmaxlen > 1 (eg. utf8mb4)
|
@dutow has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Can you update |
Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: 915b131
|
@dutow has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: 915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: #947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: a00cb7a
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: 915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: #947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 20, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
…#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Reviewed By: hermanlee Differential Revision: D13972586 Pulled By: hermanlee fbshipit-source-id: 310bf42
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
) (percona#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook/mysql-5.6@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook/mysql-5.6#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…#947) (facebook#947) Summary: Jira issue: https://jira.percona.com/browse/FB8-49 Reference patch: facebook@915b131 MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly. Pull Request resolved: facebook#947 Differential Revision: D13972586 Pulled By: hermanlee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://jira.percona.com/browse/FB8-49
Reference patch: 915b131
MySQL client doesn't remove padding chars for binary columns. Do the same for RBR. Tools parsing the replication stream vs. the client output can then use memcmp to compare keys. Otherwise, the tools need to handle padding characters correctly.