FB8-96: Remove special formatting for user name when writing to audit plugin log #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR title should be FB8-96 |
dutow
changed the title
dutow
changed the title
hermanlee
changed the title
hermanlee
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
requested changes
Feb 5, 2019
There was a problem hiding this comment.
Looks like this doesn't build with a reference to make_user_name in log.cc.
/trunk-git-mysql/sql/log.cc: In member function ‘bool Query_logger::general_log_write(THD*, enum_server_command, const char*, size_t)’:
/trunk-git-mysql/sql/log.cc:1414:61: error: ‘make_user_name’ was not declared in this scope
make_user_name(thd->security_context(), user_host_buff);
… plugin log Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: 3b47dae Reference patch: 87e0683
|
@dutow has updated the pull request. Re-import the pull request |
|
Ops, that file shouldn't have been part of the diff, fixed it. |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Feb 7, 2019
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 20, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
… plugin log (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lth Differential Revision: D13941932 Pulled By: lth fbshipit-source-id: a0ff808
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 15, 2024
… plugin log (percona#948) (percona#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook/mysql-5.6@3b47dae Reference patch: facebook/mysql-5.6@87e0683 Pull Request resolved: facebook/mysql-5.6#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
… plugin log (percona#948) (percona#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook/mysql-5.6@3b47dae Reference patch: facebook/mysql-5.6@87e0683 Pull Request resolved: facebook/mysql-5.6#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
… plugin log (percona#948) (percona#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook/mysql-5.6@3b47dae Reference patch: facebook/mysql-5.6@87e0683 Pull Request resolved: facebook/mysql-5.6#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 12, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 13, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
… plugin log (facebook#948) (facebook#948) Summary: Jira issue: https://jira.percona.com/browse/FB8-96 Reference patch: facebook@3b47dae Reference patch: facebook@87e0683 Pull Request resolved: facebook#948 Reviewed By: lloyd Differential Revision: D13941932 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://jira.percona.com/browse/FB8-96
Reference patch: 3b47dae
Reference patch: 87e0683