-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FB8-84: Add global variable max_nonsuper_connections
#950
Conversation
PR was updated and it is ready for 2nd review. |
PR was updated according to comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
max_nonsuper_connections
max_nonsuper_connections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a ---------- facebook@478fa2a ---------- Add global variable `max_nonsuper_connections` Summary: The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. fbshipit-source-id: 7ffb140
@inikep has updated the pull request. Re-import the pull request |
This commit was rebased. Because of conflicts I removed changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: 478fa2a The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: #950 Reviewed By: lth Differential Revision: D13987618 Pulled By: lth fbshipit-source-id: 4939498
Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: 478fa2a The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: #950 Reviewed By: lth Differential Revision: D13987618 Pulled By: lth fbshipit-source-id: 39039af
Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lth Differential Revision: D13987618 Pulled By: lth fbshipit-source-id: 39039af
Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lth Differential Revision: D13987618 Pulled By: lth fbshipit-source-id: 39039af
Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lth Differential Revision: D13987618 Pulled By: lth fbshipit-source-id: 39039af
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…ercona#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook/mysql-5.6@478fa2a Reference Patch: facebook/mysql-5.6@8a269ee4f97 Reference Patch: facebook/mysql-5.6@c53bf248a27 Reference Patch: facebook/mysql-5.6@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook/mysql-5.6#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
…facebook#950) Summary: JIRA: https://jira.percona.com/browse/FB8-84 Reference Patch: facebook@478fa2a Reference Patch: facebook@8a269ee4f97 Reference Patch: facebook@c53bf248a27 Reference Patch: facebook@ae0d38ae0c8 The new global variable `max_nonsuper_connections` will enforce the limit for the sum of all non-admin connections. This will be useful to limit regular user connections while still allow super users to connect to server. Pull Request resolved: facebook#950 Reviewed By: lloyd Differential Revision: D13987618 Pulled By: lth
Because of conflicts I removed changes in
mysql-test/t/all_persisted_variables.test
. This test has to be modified atlet $total_persistent_vars=XXX;
(+1 increase) and it should be re-recorded.