Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB8-80: Display row information in processlist for rbr threads #953

Closed
wants to merge 1 commit into from

Conversation

inikep
Copy link
Contributor

@inikep inikep commented Feb 7, 2019

Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: 564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.

Test Plan: mtr

Originally Reviewed By: tianx

Copy link
Contributor

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(just minor stylistic comments)

sql/rpl_record.cc Outdated Show resolved Hide resolved
sql/rpl_record.cc Outdated Show resolved Hide resolved
sql/rpl_record.cc Outdated Show resolved Hide resolved
sql/rpl_record.cc Outdated Show resolved Hide resolved
sql/rpl_record.h Outdated Show resolved Hide resolved
sql/sql_show.cc Outdated Show resolved Hide resolved
sql/sql_show.cc Outdated Show resolved Hide resolved
@inikep inikep changed the title WIP FB8-80: Display row information in processlist for rbr threads FB8-80: Display row information in processlist for rbr threads Feb 12, 2019
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@hermanlee hermanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but the follow tests look to be failing:

rpl.rpl_multi_source_row_stages
rpl.rpl_invalid_mem_access_with_rows_query_log_event

@facebook-github-bot
Copy link

@inikep has updated the pull request. Re-import the pull request

Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Summary: Set row_query using the fields unpacked from the row event. Use row_query in show processlist.

Test Plan: mtr

Reviewers: tianx

Originally Reviewed By: tianx

Subscribers: webscalesql-eng, ebergen
@facebook-github-bot
Copy link

@inikep has updated the pull request. Re-import the pull request

@inikep
Copy link
Contributor Author

inikep commented Mar 1, 2019

Failing tests were fixed and the commit was rebased.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hermanlee hermanlee closed this Mar 11, 2019
facebook-github-bot pushed a commit that referenced this pull request Mar 11, 2019
Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: 564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: #953

Reviewed By: lth

Differential Revision: D14137212

Pulled By: lth

fbshipit-source-id: ba5ad2d
facebook-github-bot pushed a commit that referenced this pull request Nov 18, 2019
Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: 564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: #953

Test Plan:
mtr

Originally Reviewed By: tianx

Reviewed By: lth

Differential Revision: D14137212

Pulled By: lth

fbshipit-source-id: 16452e4
@inikep inikep deleted the FB8-80 branch January 7, 2020 10:28
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 21, 2020
…ook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Test Plan:
mtr

Originally Reviewed By: tianx

Reviewed By: lth

Differential Revision: D14137212

Pulled By: lth

fbshipit-source-id: 16452e4
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 23, 2020
…ook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Test Plan:
mtr

Originally Reviewed By: tianx

Reviewed By: lth

Differential Revision: D14137212

Pulled By: lth

fbshipit-source-id: 16452e4
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 28, 2020
…ook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Test Plan:
mtr

Originally Reviewed By: tianx

Reviewed By: lth

Differential Revision: D14137212

Pulled By: lth

fbshipit-source-id: 16452e4
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 28, 2020
…ook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Test Plan:
mtr

Originally Reviewed By: tianx

Reviewed By: lth

Differential Revision: D14137212

Pulled By: lth

fbshipit-source-id: 16452e4
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 18, 2023
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/percona-server that referenced this pull request Apr 15, 2024
…na#953) (percona#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook/mysql-5.6@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook/mysql-5.6#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/percona-server that referenced this pull request Apr 16, 2024
…na#953) (percona#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook/mysql-5.6@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook/mysql-5.6#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/percona-server that referenced this pull request Apr 17, 2024
…na#953) (percona#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook/mysql-5.6@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook/mysql-5.6#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Apr 23, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Apr 25, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 7, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 8, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 9, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 10, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 13, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 15, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 16, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 30, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 12, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 13, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 14, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 19, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 20, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 21, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 25, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 2, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 31, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 2, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 6, 2024
…ook#953) (facebook#953)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-80

Reference Patch: facebook@564824a

Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Pull Request resolved: facebook#953

Reviewed By: lloyd

Differential Revision: D14137212

Pulled By: lth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants