-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FB8-80: Display row information in processlist for rbr threads #953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(just minor stylistic comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but the follow tests look to be failing:
rpl.rpl_multi_source_row_stages
rpl.rpl_invalid_mem_access_with_rows_query_log_event
@inikep has updated the pull request. Re-import the pull request |
Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Summary: Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Test Plan: mtr Reviewers: tianx Originally Reviewed By: tianx Subscribers: webscalesql-eng, ebergen
@inikep has updated the pull request. Re-import the pull request |
Failing tests were fixed and the commit was rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: 564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: #953 Reviewed By: lth Differential Revision: D14137212 Pulled By: lth fbshipit-source-id: ba5ad2d
Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: 564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: #953 Test Plan: mtr Originally Reviewed By: tianx Reviewed By: lth Differential Revision: D14137212 Pulled By: lth fbshipit-source-id: 16452e4
…ook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Test Plan: mtr Originally Reviewed By: tianx Reviewed By: lth Differential Revision: D14137212 Pulled By: lth fbshipit-source-id: 16452e4
…ook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Test Plan: mtr Originally Reviewed By: tianx Reviewed By: lth Differential Revision: D14137212 Pulled By: lth fbshipit-source-id: 16452e4
…ook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Test Plan: mtr Originally Reviewed By: tianx Reviewed By: lth Differential Revision: D14137212 Pulled By: lth fbshipit-source-id: 16452e4
…ook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Test Plan: mtr Originally Reviewed By: tianx Reviewed By: lth Differential Revision: D14137212 Pulled By: lth fbshipit-source-id: 16452e4
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…na#953) (percona#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook/mysql-5.6@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook/mysql-5.6#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…na#953) (percona#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook/mysql-5.6@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook/mysql-5.6#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…na#953) (percona#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook/mysql-5.6@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook/mysql-5.6#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
…ook#953) (facebook#953) Summary: Jira ticket: https://jira.percona.com/browse/FB8-80 Reference Patch: facebook@564824a Set row_query using the fields unpacked from the row event. Use row_query in show processlist. Pull Request resolved: facebook#953 Reviewed By: lloyd Differential Revision: D14137212 Pulled By: lth
Jira ticket: https://jira.percona.com/browse/FB8-80
Reference Patch: 564824a
Set row_query using the fields unpacked from the row event. Use row_query in show processlist.
Test Plan: mtr
Originally Reviewed By: tianx