FB8-50, FB8-51: Add stats to track network errors on the server side. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikep
changed the title
percona-ysorokin
suggested changes
Feb 13, 2019
laurynas-biveinis
suggested changes
Feb 14, 2019
inikep
force-pushed
the
FB8-50
branch
2 times, most recently
from
6080dc7 to
e9cdcaf
Compare
|
PR was updated according to comments |
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
requested changes
Feb 22, 2019
sql/sql_connect.cc
Outdated
| } | ||
|
|
||
| mysql_mutex_assert_not_owner(&LOCK_status); | ||
| mysql_mutex_lock(&LOCK_status); |
There was a problem hiding this comment.
Can we make all of the statistics variables atomic, similar to connection_errors_select? Then we don't need to grab the LOCK_status() during connection cleanup for this.
|
@inikep has updated the pull request. Re-import the pull request |
|
With updated PR variables were converted to std::atomic, but PR was not tested with Jenkins yet |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. ---------- facebook@8d520fd ---------- Add stats to track network errors on the server side. Summary: Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Test Plan: Run newly added unit test Reviewers: ebergen, pengt Originally Reviewed By: pengt ---------- facebook@0e62abd ---------- Group user network errors by error code. Summary: Currently the code, reports network errors across all clients by error code but reports the total network error experienced by each client. It will be beneficial to group network errors per user as well by the error code. Test Plan: Run newly added unit test Reviewers: ebergen, pengt Originally Reviewed By: pengt
|
@inikep has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Mar 1, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 6, 2019
…#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: 8d520fd Reference Patch: 0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: #960 Differential Revision: D14193990 fbshipit-source-id: 48869e5
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…percona#960) (percona#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook/mysql-5.6@8d520fd Reference Patch: facebook/mysql-5.6@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook/mysql-5.6#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…facebook#960) (facebook#960) Summary: Jira issue: https://jira.percona.com/browse/FB8-50 Jira issue: https://jira.percona.com/browse/FB8-51 Reference Patch: facebook@8d520fd Reference Patch: facebook@0e62abd Notice: Network errors per user for I_S.USER_STATISTICS were dropped. Currently there are no stats to capture the network errors while communicating with the client. These stats will help better understand the server perspective while debugging client side issues. Pull Request resolved: facebook#960 Differential Revision: D14193990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Jira issue: https://jira.percona.com/browse/FB8-50
Jira issue: https://jira.percona.com/browse/FB8-51
Reference Patch: 8d520fd
Reference Patch: 0e62abd
Notice: Network errors per user for I_S.USER_STATISTICS were dropped.
Currently there are no stats to capture the network errors while
communicating with the client. These stats will help better understand the
server perspective while debugging client side issues.
Test Plan: Run newly added unit test
Originally Reviewed By: pengt