FB8-131: Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurynas-biveinis
suggested changes
Feb 25, 2019
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
inikep
force-pushed
the
FB8-131
branch
3 times, most recently
from
c4d2a3c to
55ed55b
Compare
|
PR was updated according to comments |
percona-ysorokin
suggested changes
Feb 25, 2019
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
|
PR was updated |
percona-ysorokin
approved these changes
Feb 26, 2019
mysql-test/suite/rpl/t/rpl_semi_sync_master_crash_if_active_trxs.test
Outdated
Show resolved
Hide resolved
inikep
force-pushed
the
FB8-131
branch
2 times, most recently
from
afa0d77 to
1c762d0
Compare
… while there are active un-acked trxns Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 ---------- facebook@2d47615 ---------- Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Summary: Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Originally Reviewed By: hermanlee fbshipit-source-id: facebook@c378441 ---------- facebook@d1ea741 ---------- Fix test flakiness in rpl.rpl_semi_sync-master_crash_if_active_trxs Summary: The test would sometimes fail if the slave's retry count is exhausted before the master comes up. Set the slave to retry forever instead. Squash with D5841339 Originally Reviewed By: abhinav04sharma fbshipit-source-id: facebook@c12f822 ---------- facebook@f5085f4 ---------- Use master_retry_count to fix rpl.rpl_semi_sync_master_crash_if_active_trxs Summary: The proper variable to adjust is master_retry_count, not master_connect_retry. Squash with D5841339 Originally Reviewed By: abhinav04sharma fbshipit-source-id: facebook@6938715 ---------- facebook@9204c65 ---------- Delete pid file when crashing after timeout with unacked trx Summary: If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. This change deletes the pid file before crashing on this condition. Squash with D5841339 Originally Reviewed By: Tema fbshipit-source-id: facebook@a94df24
inikep
changed the title
There was a problem hiding this comment.
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
lth
approved these changes
Mar 7, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2019
… while there are active un-acked trxns (#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: 2d47615 Reference Patch: d1ea741 Reference Patch: f5085f4 Reference Patch: 9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: #966 Reviewed By: hermanlee Differential Revision: D14308888 Pulled By: hermanlee fbshipit-source-id: f314c5b
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
… while there are active un-acked trxns (#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: 2d47615 Reference Patch: d1ea741 Reference Patch: f5085f4 Reference Patch: 9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: #966 Reviewed By: hermanlee Differential Revision: D14308888 Pulled By: hermanlee fbshipit-source-id: ab615fe
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 21, 2020
… while there are active un-acked trxns (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Reviewed By: hermanlee Differential Revision: D14308888 Pulled By: hermanlee fbshipit-source-id: ab615fe
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
… while there are active un-acked trxns (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Reviewed By: hermanlee Differential Revision: D14308888 Pulled By: hermanlee fbshipit-source-id: ab615fe
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 15, 2024
… while there are active un-acked trxns (percona#966) (percona#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook/mysql-5.6@2d47615 Reference Patch: facebook/mysql-5.6@d1ea741 Reference Patch: facebook/mysql-5.6@f5085f4 Reference Patch: facebook/mysql-5.6@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook/mysql-5.6#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
… while there are active un-acked trxns (percona#966) (percona#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook/mysql-5.6@2d47615 Reference Patch: facebook/mysql-5.6@d1ea741 Reference Patch: facebook/mysql-5.6@f5085f4 Reference Patch: facebook/mysql-5.6@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook/mysql-5.6#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
… while there are active un-acked trxns (percona#966) (percona#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook/mysql-5.6@2d47615 Reference Patch: facebook/mysql-5.6@d1ea741 Reference Patch: facebook/mysql-5.6@f5085f4 Reference Patch: facebook/mysql-5.6@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook/mysql-5.6#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 13, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
… while there are active un-acked trxns (facebook#966) (facebook#966) Summary: Jira issue: https://jira.percona.com/browse/FB8-131 Reference Patch: facebook@2d47615 Reference Patch: facebook@d1ea741 Reference Patch: facebook@f5085f4 Reference Patch: facebook@9204c65 Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns Semi-sync master can be switched off manually or because of a timeout while waiting for an ack. This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs which when set to true will cause the master to shutdown (after printing an error msg) if semi-sync is being switched off while there are active un-acked transactions. This prevents any un-acked trx from committing on the master. Also delete pid file when crashing after timeout with unacked trx. If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a timeout if there are any active unacked transactions. mysqld_safe expects the pid file to be deleted if the expectation is to not bring the intance back up again. Pull Request resolved: facebook#966 Differential Revision: D14308888 Pulled By: hermanlee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: https://jira.percona.com/browse/FB8-131
Reference Patch: 2d47615
Reference Patch: d1ea741
Reference Patch: f5085f4
Reference Patch: 9204c65
---------- 2d47615 ----------
Option to shutdown master if semi-sync is being switched off while there are active un-acked trxns
Summary:
Semi-sync master can be switched off manually or because of a timeout while
waiting for an ack.
This change introduces a new variable rpl_semi_sync_master_crash_if_active_trxs
which when set to true will cause the master to shutdown (after printing an
error msg) if semi-sync is being switched off while there are active un-acked
transactions. This prevents any un-acked trx from committing on the
master.
Originally Reviewed By: hermanlee
fbshipit-source-id: c378441
---------- d1ea741 ----------
Fix test flakiness in rpl.rpl_semi_sync-master_crash_if_active_trxs
Summary:
The test would sometimes fail if the slave's retry count is exhausted
before the master comes up. Set the slave to retry forever instead.
Squash with D5841339
Originally Reviewed By: abhinav04sharma
fbshipit-source-id: c12f822
---------- f5085f4 ----------
Use master_retry_count to fix rpl.rpl_semi_sync_master_crash_if_active_trxs
Summary:
The proper variable to adjust is master_retry_count, not
master_connect_retry.
Squash with D5841339
Originally Reviewed By: abhinav04sharma
fbshipit-source-id: 6938715
---------- 9204c65 ----------
Delete pid file when crashing after timeout with unacked trx
Summary:
If rpl_semi_sync_master_crash_if_active_trxs = true, the server crashes after a
timeout if there are any active unacked transactions. mysqld_safe expects the
pid file to be deleted if the expectation is to not bring the intance back up
again. This change deletes the pid file before crashing on this condition.
Squash with D5841339
Originally Reviewed By: Tema
fbshipit-source-id: a94df24