FB8-187: New variable binlog_rows_event_max_rows to control the number of rows in a single rows event #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percona-ysorokin
suggested changes
Feb 28, 2019
inikep
force-pushed
the
FB8-187
branch
2 times, most recently
from
6e01b2f to
d6c6d17
Compare
|
All comments were addressed, fixed |
…r of rows in a single rows event Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Summary: Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb fbshipit-source-id: bfb8492
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Mar 22, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2019
…r of rows in a single rows event (#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: #974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b889377
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
…r of rows in a single rows event (#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: #974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 21, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 23, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
…r of rows in a single rows event (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lth Differential Revision: D14421324 Pulled By: lth fbshipit-source-id: b410b57
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…r of rows in a single rows event (percona#974) (percona#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook/mysql-5.6@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook/mysql-5.6#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…r of rows in a single rows event (facebook#974) (facebook#974) Summary: Jira issue: https://jira.percona.com/browse/FB8-187 Reference Patch: facebook@dfe6746cdfd Number of rows in a single event can be indirectly controlled with binlog_rows_event_max_size. This new variable will give more direct control to the user. Originally Reviewed By: anirbanr-fb Pull Request resolved: facebook#974 Reviewed By: lloyd Differential Revision: D14421324 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Jira issue: https://jira.percona.com/browse/FB8-187
Reference Patch: dfe6746cdfd
Number of rows in a single event can be indirectly controlled with
binlog_rows_event_max_size. This new variable will give more direct control to
the user.
Originally Reviewed By: anirbanr-fb
Todo: Because of conflicts I removed changes in
mysql-test/t/all_persisted_variables.test. This test has to be modified atlet $total_persistent_vars=XXX;(+1 increase) and it should be re-recorded.