-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FB8-186: Extend mysqld_safe to LD_PRELOAD shared libraries #979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 Summary: This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee fbshipit-source-id: cf79abf
percona-ysorokin
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
inikep
changed the title
WIP FB8-186: Extend mysqld_safe to LD_PRELOAD shared libraries
FB8-186: Extend mysqld_safe to LD_PRELOAD shared libraries
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: 16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: #979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: ef061ca
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: 16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: #979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 21, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lth Differential Revision: D14335103 Pulled By: lth fbshipit-source-id: b604e02
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 11, 2021
) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 (facebook@3e72f69) Pulled By: lth fbshipit-source-id: 7ca49a3cb58
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 14, 2021
) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 (facebook@3e72f69) Pulled By: lth fbshipit-source-id: 7ca49a3cb58
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 15, 2021
) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 (facebook@3e72f69) Pulled By: lth fbshipit-source-id: 7ca49a3cb58
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 15, 2021
) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 (facebook@3e72f69) Pulled By: lth fbshipit-source-id: 7ca49a3cb58
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 (facebook@3e72f69) Pulled By: lth fbshipit-source-id: 7ca49a3cb58
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…ies (percona#979) (percona#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook/mysql-5.6@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook/mysql-5.6#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 10, 2024
…ies (percona#979) (percona#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook/mysql-5.6@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook/mysql-5.6#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 12, 2024
…ies (percona#979) (percona#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook/mysql-5.6@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook/mysql-5.6#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 15, 2024
…ies (percona#979) (percona#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook/mysql-5.6@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook/mysql-5.6#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
…ies (percona#979) (percona#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook/mysql-5.6@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook/mysql-5.6#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…ies (percona#979) (percona#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook/mysql-5.6@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook/mysql-5.6#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 5, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 6, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 6, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 6, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 7, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 10, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 10, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 13, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…ies (facebook#979) (facebook#979) Summary: Jira issue: https://jira.percona.com/browse/FB8-186 Reference Patch: facebook@16b02494411 This will allow us to override some glibc functions like localtime_r. Originally Reviewed By: hermanlee Pull Request resolved: facebook#979 Reviewed By: lloyd Differential Revision: D14335103 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Jira issue: https://jira.percona.com/browse/FB8-186
Reference Patch: 16b02494411
This will allow us to override some glibc functions like localtime_r.
Originally Reviewed By: hermanlee