FB8-46: Port v5.1 Extra Stats: Command Timers #989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanlee
force-pushed
the
fb-mysql-8.0.13
branch
from
e9926c3 to
c3bd1c6
Compare
…k errors on the server side"
Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669072f0 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e1681024 Summary: Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Test Plan: Jenkins. All tests, including the new one, pass. Reviewers: chip Originally Reviewed By: chip
inikep
changed the title
There was a problem hiding this comment.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hermanlee
approved these changes
Apr 15, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 15, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: f2d6fdc With additional improvements: 1. Variables moved from global to session from 459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from 4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: #989 Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 0408f15
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: f2d6fdc With additional improvements: 1. Variables moved from global to session from 459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from 4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: #989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 24, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 28, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 29, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 10, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 7, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Test Plan: Jenkins. All tests, including the new one, pass. Reviewed By: yizhang82 Differential Revision: D14883715 Pulled By: yizhang82 fbshipit-source-id: 7e8f75d
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook/mysql-5.6@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook/mysql-5.6@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook/mysql-5.6@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook/mysql-5.6#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 23, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 25, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 20, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 21, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 25, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 2, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
inikep
added a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
…k#989) Summary: Jira issue: https://jira.percona.com/browse/FB8-46 Reference Patch: facebook@f2d6fdc With additional improvements: 1. Variables moved from global to session from facebook@459f669 2. Added time tracking for "sp_instr_stmt::exec_core", "mysql_open_cursor", "Execute_sql_statement::execute_server_code" and "Prepared_statement::execute" from facebook@4554e16 Adds command, slave_command, pre-exec, parse, and execution timers. This ports these timers from v5.1 to 5.6, using the new timers. I also added an mtr test to confirm they are at least partly working. Originally Reviewed By: chip Pull Request resolved: facebook#989 Differential Revision: D14883715 Pulled By: yizhang82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Jira issue: https://jira.percona.com/browse/FB8-46
Reference Patch: f2d6fdc
With additional improvements:
Adds command, slave_command, pre-exec, parse, and execution timers.
This ports these timers from v5.1 to 5.6, using the new timers.
I also added an mtr test to confirm they are at least partly working.
Originally Reviewed By: chip
Test Plan: Jenkins. All tests, including the new one, pass.