-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FB8-79: Add option to mysqlbinlog to print encountered gtids on exit #994
Conversation
client/mysqlbinlog.cc
Outdated
@@ -1066,6 +1077,21 @@ void handle_last_rows_query_event(bool print, | |||
last_rows_query_event.event_pos = 0; | |||
} | |||
|
|||
// Helper for next function | |||
static bool encounter_gtid(Gtid cached_gtid) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass by value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
e9926c3
to
c3bd1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Laurynas' comment addressed.
Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: 49f77bd Reference commit: 2306b6e Reference commit: eaa782f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 fbshipit-source-id: afbe989
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 (facebook@f219b9a) fbshipit-source-id: 3c15f90d081
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 (facebook@f219b9a) fbshipit-source-id: 3c15f90d081
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835 (facebook@f219b9a) fbshipit-source-id: 3c15f90d081
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…ercona#994) (percona#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook/mysql-5.6@49f77bd Reference commit: facebook/mysql-5.6@2306b6e Reference commit: facebook/mysql-5.6@eaa782f Pull Request resolved: facebook/mysql-5.6#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
…acebook#994) (facebook#994) Summary: Jira ticket: https://jira.percona.com/browse/FB8-79 Reference commit: facebook@49f77bd Reference commit: facebook@2306b6e Reference commit: facebook@eaa782f Pull Request resolved: facebook#994 Differential Revision: D14883835
Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79
Reference commit: 49f77bd
Reference commit: 2306b6e
Reference commit: eaa782f
Adds the --print_gtids option to mysqlbinlog to display the gtids processed.