Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB8-79: Add option to mysqlbinlog to print encountered gtids on exit #994

Closed
wants to merge 1 commit into from

Conversation

dutow
Copy link
Contributor

@dutow dutow commented Mar 19, 2019

Summary:

Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: 49f77bd
Reference commit: 2306b6e
Reference commit: eaa782f

Adds the --print_gtids option to mysqlbinlog to display the gtids processed.

@@ -1066,6 +1077,21 @@ void handle_last_rows_query_event(bool print,
last_rows_query_event.event_pos = 0;
}

// Helper for next function
static bool encounter_gtid(Gtid cached_gtid) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass by value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Contributor

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Laurynas' comment addressed.

@dutow dutow changed the title WIP FB8-79: Add option to mysqlbinlog to print encountered gtids on exit FB8-79: Add option to mysqlbinlog to print encountered gtids on exit Apr 1, 2019
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hermanlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hermanlee hermanlee closed this Apr 17, 2019
facebook-github-bot pushed a commit that referenced this pull request Apr 17, 2019
…994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: 49f77bd
Reference commit: 2306b6e
Reference commit: eaa782f
Pull Request resolved: #994

Differential Revision: D14883835

fbshipit-source-id: cc474d7
facebook-github-bot pushed a commit that referenced this pull request Nov 18, 2019
…994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: 49f77bd
Reference commit: 2306b6e
Reference commit: eaa782f
Pull Request resolved: #994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 24, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 28, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 28, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 29, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 10, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 10, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 7, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 9, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Oct 5, 2020
…acebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835

fbshipit-source-id: afbe989
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Mar 11, 2021
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835 (facebook@f219b9a)

fbshipit-source-id: 3c15f90d081
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 16, 2021
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835 (facebook@f219b9a)

fbshipit-source-id: 3c15f90d081
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 2, 2021
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835 (facebook@f219b9a)

fbshipit-source-id: 3c15f90d081
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 23, 2023
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 3, 2023
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 18, 2023
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/percona-server that referenced this pull request Apr 17, 2024
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Apr 23, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Apr 23, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Apr 25, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 7, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 8, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 9, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 10, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 13, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 15, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 16, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 30, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 14, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 19, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 20, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 21, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 25, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 2, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 31, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 2, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 6, 2024
…acebook#994) (facebook#994)

Summary:
Jira ticket: https://jira.percona.com/browse/FB8-79

Reference commit: facebook@49f77bd
Reference commit: facebook@2306b6e
Reference commit: facebook@eaa782f
Pull Request resolved: facebook#994

Differential Revision: D14883835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants