Skip to content

Commit

Permalink
stringify placeholder entries before adding them to the command line
Browse files Browse the repository at this point in the history
Summary: `placeholders` don't have to be strings, but `cmd_args` expects us to add a string. So, call `str` on everything that we add.

Reviewed By: navidqar

Differential Revision: D51305891

fbshipit-source-id: 41c7a31631908f3e689ce5a82f6883d8685a7308
  • Loading branch information
Ian Childs authored and facebook-github-bot committed Nov 14, 2023
1 parent 2c3be58 commit 0a7d2e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prelude/android/android_manifest.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def generate_android_manifest(

placeholder_entries_args = cmd_args()
for key, val in placeholder_entries.items():
placeholder_entries_args.add(cmd_args(key, val, delimiter = " "))
placeholder_entries_args.add(cmd_args(str(key), str(val), delimiter = " "))
placeholder_entries_file = ctx.actions.write("{}/placeholder_entries_file".format(module_name), placeholder_entries_args)

generate_manifest_cmd.add(["--placeholder-entries-list", placeholder_entries_file])
Expand Down

0 comments on commit 0a7d2e5

Please sign in to comment.