Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
buck2 for voltron language packs - 2
Summary: Same like D51217538 Fix S378631, It use buck2 build m4a build like [automation_messenger_for_perftest_playstoretest](D27298583) from v434, and the voltron language pack only contains 75k, see here https://www.internalfb.com/intern/mobile/buildinfo/buildinfo/?build=534694874 , I found out it is caused by buck2 it didn't build correct number of voltron string resources. The repro way is to build following command ``` buck2 build --show-output fbsource//fbandroid/apps/messenger:messenger_staticdi_dlstr_arm64_filtered_str_debug#generate_voltron_string_resources ``` And the output only contains 10+ folders, if we check the path folder in `resource_dirs_for_voltron_string_source_map`, we will find out the it used filtered_res, which is for non-voltron language packs. I checked the code and find out the fix can be just provide the correct folder, since the voltron folder was already there, but never correctly being used. Reviewed By: luluonet Differential Revision: D51228314 fbshipit-source-id: 3e65f1bca43bb21374c9dea954027ac5207d315c
- Loading branch information