Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse hashers by hasher.finalize_reset() #129

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Reuse hashers by hasher.finalize_reset() #129

merged 1 commit into from
Feb 5, 2021

Conversation

kchalkias
Copy link
Contributor

This is preferred (especially in loops) as it's sometimes faster than reconstructing the hasher object.
See function's docs

@kchalkias kchalkias requested a review from kevinlewi February 5, 2021 01:04
kevinlewi
kevinlewi approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kchalkias kchalkias merged commit 1f608e4 into master Feb 5, 2021
@kchalkias kchalkias deleted the kostas-hasher-reuse branch February 5, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchalkias @kevinlewi @facebook-github-bot