This repository has been archived by the owner on Sep 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 356
Add expected types to oneOfType warning #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds data object to returned error in checker so that the expected types can be accessed from within oneOfType check. Also, updates the tests slightly. Fixes facebook#9.
joshalling
force-pushed
the
one-of-type-warnings
branch
2 times, most recently
from
July 21, 2018 05:05
22a6083
to
587cb59
Compare
joshalling
changed the title
Add expected types to oneOfType warning (#9)
Add expected types to oneOfType warning
Jul 21, 2018
ljharb
force-pushed
the
one-of-type-warnings
branch
from
February 10, 2019 22:09
587cb59
to
c524af5
Compare
ljharb
approved these changes
Feb 28, 2019
ljharb
force-pushed
the
one-of-type-warnings
branch
from
February 28, 2019 04:34
c524af5
to
3910873
Compare
❤️ |
ljharb
reviewed
Jan 5, 2022
return null; | ||
} | ||
if (checkerResult.data.hasOwnProperty('expectedType')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for posterity: assuming .data
exists, and also calling .hasOwnProperty
directly off of an object, caused #369.
This was referenced May 24, 2024
Open
This was referenced Jun 18, 2024
This was referenced Jul 19, 2024
This was referenced Sep 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds data object to returned error in type checker so that the expected types can be accessed from within oneOfType check. Also, updates the tests slightly.
Fixes #9. Fixes facebook/react#1919.